Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace action ETOs publishing with the integration services #22

Open
gdlcf88 opened this issue May 24, 2022 · 0 comments
Open

Replace action ETOs publishing with the integration services #22

gdlcf88 opened this issue May 24, 2022 · 0 comments

Comments

@gdlcf88
Copy link
Member

gdlcf88 commented May 24, 2022

After the issue abpframework/abp#12470 is complete, we can use the new integration service to replace most action ETOs publishing.

The reasons:

  1. The request side can get results immediately by invoking an integration service, but the action events can't.
  2. Idempotency cannot always implement. Assume I am not using ABP's event inbox, or I implement it in another way. If a CreatePaymentEto action event is received more than once, we can avoid double-creating the payment by checking the payment entity with the same ItemName+ItemKey exists. But thinking about the CreateIssueEto, we should allow issues with the same title/content created.
@gdlcf88 gdlcf88 changed the title Replace action ETOs with the integration services Replace publishing action ETOs with the integration services May 24, 2022
@gdlcf88 gdlcf88 changed the title Replace publishing action ETOs with the integration services Replace action ETOs publishing with the integration services May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant