[chore] Update create_verify unit test with better invalid address #540
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The unit test for testing the "verify" parameter on address creation was broken due to recent updates to downstream shipper systems that no longer considered the "incorrect" address we were sending to be incorrect.
To avoid having to find another "incorrect" address combination to trigger the original assertions, the unit test has been rewritten to send a guaranteed-incorrect address to the API, showcasing the difference in responses (the presence of delivery and/or zip4 verifications) based on whether the "verify" parameter was included.
This shifts the unit test away from having to account for server-side or downstream errors, and instead more closely tests what we're actually trying to test, that the "verify" parameter is being sent or not sent to the API, and that "verifications" are being deserialized properly from the response.
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.