Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Make base EasyPostService extendable outside module #543

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

nwithan8
Copy link
Contributor

Description

The EasyPostService base class used for all services (e.g. UserService) was marked internal, meaning it could not be constructed or extended outside of the EasyPost module. This PR instead sets it to protected, meaning it can still not be constructed directly, but can be inherited. This can be helpful for end-users trying to make extensions or custom implementations of the services, allowing them to use the base service rather than having to re-implement all client HTTP functionality themselves.

Testing

  • All unit tests pass
  • Change does not affect compilation, run-time or linting

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@nwithan8 nwithan8 requested a review from a team January 11, 2024 22:14
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not

@nwithan8 nwithan8 merged commit 7202a83 into master Jan 12, 2024
14 checks passed
@nwithan8 nwithan8 deleted the extension branch January 12, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants