-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Add missing parameters for creating orders #561
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get some tests for these or some e2e tests? Orders are kind of tricky where most of these details will typically be on each shipment and not on the parent order (addresses aside). I'd like to avoid adding params that aren't valid at the parent level by testing first.
In draft while discussed internally. |
We have confirmed internally that these parameters are accepted in certain multi-parcel scenarios. It's not guaranteed that they will always be respected versus ignored, but it's important that we make them available for end-users to use as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel better with just exposing return/buyer addresses
Description
BuyerAddress
andReturnAddress
parameters forOrder.Create
parameter setTesting
Pull Request Type
Please select the option(s) that are relevant to this PR.