Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: coverage report generation #491

Merged
merged 1 commit into from
Feb 4, 2025
Merged

fix: coverage report generation #491

merged 1 commit into from
Feb 4, 2025

Conversation

Justintime50
Copy link
Member

@Justintime50 Justintime50 commented Feb 4, 2025 •
edited
Loading

Description

After switching to Vitetest, the code coverage report generation was altered. This change now generates the HTML for humans along with lcov needed for coveralls

Testing

Ran make coverage and inspected the lcov.info file was output

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@Justintime50 Justintime50 requested a review from a team as a code owner February 4, 2025 20:34
ralexmatthews
ralexmatthews approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@ralexmatthews ralexmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick 🔥

@Justintime50 Justintime50 merged commit 6ac0cc3 into master Feb 4, 2025
17 checks passed
@Justintime50 Justintime50 deleted the fix_coverage_generation branch February 4, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexmatthews ralexmatthews ralexmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Justintime50 @ralexmatthews