Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types fix #492

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Types fix #492

merged 2 commits into from
Feb 5, 2025

Conversation

ralexmatthews
Copy link
Contributor

Description

This fixes an issue having to do with the type defs. The problem was since the app was changed to not have a .default export anymore, we couldn't use that in the type defs.

This updates it to support the default export in both CJS and ESM syntax

CleanShot 2025-02-05 at 10 25 02@2x
CleanShot 2025-02-05 at 10 25 17@2x

Testing

This is just a types change, so there should be no issue with the code itself.

I tested the code worked by creating a new node project and adding the project as a dep and checking the types were there.

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

@ralexmatthews ralexmatthews merged commit 8821d1e into master Feb 5, 2025
17 checks passed
@ralexmatthews ralexmatthews deleted the types-fix branch February 5, 2025 17:49
@matAlmeida
Copy link

Thank you @ralexmatthews. There is any ideia when this fix will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants