Skip to content

Commit e7a8662

Browse files
committed
Android: fix userMap not being used in userCallback & anonymousUserCallback
1 parent 48e2fcc commit e7a8662

File tree

1 file changed

+10
-13
lines changed

1 file changed

+10
-13
lines changed

Diff for: android/src/main/java/io/fullstack/firestack/FirestackAuth.java

+10-13
Original file line numberDiff line numberDiff line change
@@ -417,7 +417,6 @@ public void onComplete(@NonNull Task<AuthResult> task) {
417417

418418
// Internal helpers
419419
public void userCallback(FirebaseUser passedUser, final Callback onComplete) {
420-
WritableMap userMap = getUserMap();
421420

422421
if (passedUser == null) {
423422
mAuth = FirebaseAuth.getInstance();
@@ -429,14 +428,13 @@ public void userCallback(FirebaseUser passedUser, final Callback onComplete) {
429428
this.user.getToken(true).addOnCompleteListener(new OnCompleteListener<GetTokenResult>() {
430429
@Override
431430
public void onComplete(@NonNull Task<GetTokenResult> task) {
432-
WritableMap msgMap = Arguments.createMap();
433-
WritableMap userMap = Arguments.createMap();
434-
431+
WritableMap msgMap = Arguments.createMap();
432+
WritableMap userMap = getUserMap();
435433
if (FirestackAuthModule.this.user != null) {
436-
final String token = task.getResult().getToken();
434+
final String token = task.getResult().getToken();
437435

438-
userMap.putString("token", token);
439-
userMap.putBoolean("anonymous", false);
436+
userMap.putString("token", token);
437+
userMap.putBoolean("anonymous", false);
440438
}
441439

442440
msgMap.putMap("user", userMap);
@@ -448,7 +446,6 @@ public void onComplete(@NonNull Task<GetTokenResult> task) {
448446

449447
// TODO: Reduce to one method
450448
public void anonymousUserCallback(FirebaseUser passedUser, final Callback onComplete) {
451-
WritableMap userMap = getUserMap();
452449

453450
if (passedUser == null) {
454451
mAuth = FirebaseAuth.getInstance();
@@ -460,14 +457,14 @@ public void anonymousUserCallback(FirebaseUser passedUser, final Callback onComp
460457
this.user.getToken(true).addOnCompleteListener(new OnCompleteListener<GetTokenResult>() {
461458
@Override
462459
public void onComplete(@NonNull Task<GetTokenResult> task) {
463-
WritableMap msgMap = Arguments.createMap();
464-
WritableMap userMap = Arguments.createMap();
460+
WritableMap msgMap = Arguments.createMap();
461+
WritableMap userMap = getUserMap();
465462

466463
if (FirestackAuthModule.this.user != null) {
467-
final String token = task.getResult().getToken();
464+
final String token = task.getResult().getToken();
468465

469-
userMap.putString("token", token);
470-
userMap.putBoolean("anonymous", true);
466+
userMap.putString("token", token);
467+
userMap.putBoolean("anonymous", true);
471468
}
472469

473470
msgMap.putMap("user", userMap);

0 commit comments

Comments
 (0)