api: default_vitals: Fix typo that led to early bailout #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `stand_node` was present, the first guard in `default_vitals` bailed out. This was seemingly unexpected and might be a relict from the refactoring in 59602c9. There, a `not` got seemingly lost (from line ~1260 in mob_meta.lua) and was not brought over properly to api.lua. We fix the guard to bail out only if at least one of `stand_pos` or `stand_node` are missing. Noww, default_vitals actually does its work again. Fixes ElCeejo/animalia#99 Fixes ElCeejo/animalia#100 Fixes ElCeejo/animalia#78
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
stand_nodewas present, the first guard indefault_vitalsbailed out.This was seemingly unexpected and might be a relict from the refactoring in 59602c9. There, a
notgot seemingly lost (from line ~1260 in mob_meta.lua) and was not brought over properly to api.lua.We fix the guard to bail out only if at least one of
stand_posorstand_nodeare missing. Noww, default_vitals actually does its work again.Fixes ElCeejo/animalia#99
Fixes ElCeejo/animalia#100
Fixes ElCeejo/animalia#78