From 0775b91dd4acaddab70fc1a020b6c5be7de2970e Mon Sep 17 00:00:00 2001 From: Misha Gorshenin Date: Wed, 1 May 2024 09:37:38 +0500 Subject: [PATCH 1/2] fix: get back net6 support --- .github/workflows/ci.yml | 2 ++ src/ElectronNET.API/ElectronNET.API.csproj | 2 +- src/ElectronNET.CLI/ElectronNET.CLI.csproj | 3 +-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0901bd2c..a0e7cfb3 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,6 +17,7 @@ jobs: uses: actions/setup-dotnet@v4 with: dotnet-version: | + 6.0.x 8.0.x - name: Build @@ -32,6 +33,7 @@ jobs: uses: actions/setup-dotnet@v4 with: dotnet-version: | + 6.0.x 8.0.x - name: Build diff --git a/src/ElectronNET.API/ElectronNET.API.csproj b/src/ElectronNET.API/ElectronNET.API.csproj index 1f44ff76..51fb9b5e 100644 --- a/src/ElectronNET.API/ElectronNET.API.csproj +++ b/src/ElectronNET.API/ElectronNET.API.csproj @@ -1,6 +1,6 @@  - net8.0 + net6.0;net8.0 ..\..\artifacts ElectronNET.API Gregor Biswanger, Florian Rappl diff --git a/src/ElectronNET.CLI/ElectronNET.CLI.csproj b/src/ElectronNET.CLI/ElectronNET.CLI.csproj index fd30a574..5aa7182e 100644 --- a/src/ElectronNET.CLI/ElectronNET.CLI.csproj +++ b/src/ElectronNET.CLI/ElectronNET.CLI.csproj @@ -1,7 +1,7 @@  Exe - net8.0 + net6.0;net8.0 dotnet-electronize electronize DotnetCliTool @@ -25,7 +25,6 @@ Changelog: https://github.com/ElectronNET/Electron.NET/blob/main/Changelog.md PackageIcon.png true - true From 1864c21c109530839b595b0f024311c7750bfb5a Mon Sep 17 00:00:00 2001 From: Misha Gorshenin Date: Wed, 1 May 2024 12:35:06 +0500 Subject: [PATCH 2/2] fix: specify target framework --- nuke/Build.cs | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/nuke/Build.cs b/nuke/Build.cs index 0b390254..77bbe7be 100644 --- a/nuke/Build.cs +++ b/nuke/Build.cs @@ -71,6 +71,8 @@ AbsolutePath[] Projects } } + string Framework => Solution.GetProject(DemoTargetLibName).GetProperty("TargetFramework"); + protected override void OnBuildInitialized() { var parser = new ReleaseNotesParser(); @@ -184,7 +186,9 @@ protected override void OnBuildInitialized() var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj"; var args = "build /target custom win7-x86;win /dotnet-configuration Debug /electron-arch ia32 /electron-params \"--publish never\""; - DotNet($"run --project {cli} -- {args}", sample); + var cmd = $"run --project {cli} --framework {Framework} -- {args}"; + Log.Debug(cmd); + DotNet(cmd, sample); }); Target ElectronizeWindowsTargetSample => _ => _ @@ -195,7 +199,9 @@ protected override void OnBuildInitialized() var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj"; var args = "build /target win /electron-params \"--publish never\""; - DotNet($"run --project {cli} -- {args}", sample); + var cmd =$"run --project {cli} --framework {Framework} -- {args}"; + Log.Debug(cmd); + DotNet(cmd, sample); }); Target ElectronizeCustomWin7TargetSample => _ => _ @@ -206,7 +212,9 @@ protected override void OnBuildInitialized() var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj"; var args = "build /target custom win7-x86;win /electron-params \"--publish never\""; - DotNet($"run --project {cli} -- {args}", sample); + var cmd =$"run --project {cli} --framework {Framework} -- {args}"; + Log.Debug(cmd); + DotNet(cmd, sample); }); Target ElectronizeMacOsTargetSample => _ => _ @@ -217,7 +225,9 @@ protected override void OnBuildInitialized() var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj"; var args = "build /target osx /electron-params \"--publish never\""; - DotNet($"run --project {cli} -- {args}", sample); + var cmd =$"run --project {cli} --framework {Framework} -- {args}"; + Log.Debug(cmd); + DotNet(cmd, sample); }); Target ElectronizeLinuxTargetSample => _ => _ @@ -228,7 +238,9 @@ protected override void OnBuildInitialized() var cli = SourceDirectory / CliTargetLibName / $"{CliTargetLibName}.csproj"; var args = "build /target linux /electron-params \"--publish never\""; - DotNet($"run --project {cli} -- {args}", sample); + var cmd =$"run --project {cli} --framework {Framework} -- {args}"; + Log.Debug(cmd); + DotNet(cmd, sample); }); Target PublishPackages => _ => _