Skip to content

Commit

Permalink
Update electron version
Browse files Browse the repository at this point in the history
  • Loading branch information
rs22 committed May 10, 2024
1 parent 21c17dc commit ecd7459
Show file tree
Hide file tree
Showing 3 changed files with 41 additions and 23 deletions.
10 changes: 5 additions & 5 deletions src/ElectronNET.CLI/Commands/BuildCommand.cs
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,13 @@ public Task<bool> ExecuteAsync()
string tempBinPath = Path.Combine(tempPath, "bin");

Console.WriteLine($"Build ASP.NET Core App for {platformInfo.NetCorePublishRid} under {configuration}-Configuration...");

var dotNetPublishFlags = GetDotNetPublishFlags(parser);

var command =
$"dotnet publish -r {platformInfo.NetCorePublishRid} -c \"{configuration}\" --output \"{tempBinPath}\" {string.Join(' ', dotNetPublishFlags.Select(kvp => $"{kvp.Key}={kvp.Value}"))} --self-contained";
// output the command

// output the command
Console.ForegroundColor = ConsoleColor.Green;
Console.WriteLine(command);
Console.ResetColor();
Expand Down Expand Up @@ -198,7 +198,7 @@ public Task<bool> ExecuteAsync()
: $"node build-helper.js {manifestFileName} {version}", tempPath);

Console.WriteLine($"Package Electron App for Platform {platformInfo.ElectronPackerPlatform}...");
ProcessHelper.CmdExecute($"npx electron-builder --config=./bin/electron-builder.json --{platformInfo.ElectronPackerPlatform} --{electronArch} -c.electronVersion=23.2.0 {electronParams}", tempPath);
ProcessHelper.CmdExecute($"npx electron-builder --config=./bin/electron-builder.json --{platformInfo.ElectronPackerPlatform} --{electronArch} -c.electronVersion=30.0.3 {electronParams}", tempPath);

Console.WriteLine("... done");

Expand Down Expand Up @@ -252,4 +252,4 @@ private Dictionary<string, string> GetDotNetPublishFlags(SimpleCommandLineParser
return dotNetPublishFlags;
}
}
}
}
52 changes: 35 additions & 17 deletions src/ElectronNET.Host/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/ElectronNET.Host/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
},
"devDependencies": {
"@types/node": "^18.15.5",
"electron": "^23.2.0",
"electron": "^30.0.3",
"tslint": "^6.1.3",
"typescript": "^5.0.2"
}
Expand Down

0 comments on commit ecd7459

Please sign in to comment.