[EDH-3603] - Wrong response for OPEN_SUPPLIER in "agreement/search/meter"

[EinarArro]

Problem

By the business rules OS should see only limited data of other SUPPLY/GS agreements, where he is not the Service Provider.
But in reality, he can see full data of other SUPPLY agreements

Steps to reproduce

• Create new MP
• Create new GRID and SUPPLY agreements, that start in the past (to make them already active)
• Create another SUPPLY agreement with other OS, so it starts somewhere in the future (so that we have 2 different SUPPLY agreements with different OS-s).
• Check the agreements:

id	mp_eic	agreement_type	service_provider_eic	customer_eic	valid_from	valid_to	created_time	visible	deleted_time
28375624	38ZGO-10000091-V	GRID	38X-EIN-GO-----0	38X-AVP-ZW6700C6	2024-11-26 22:00		2024-11-28 13:59	True
28375627	38ZGO-10000091-V	SUPPLY	38X-EIN-OS-----J	38X-AVP-ZW6700C6	2024-11-26 22:00	2024-12-31 22:00	2024-11-28 13:59	True
28375628	38ZGO-10000091-V	SUPPLY	38X-EIN-ALL----B	38X-AVP-ZW6700C6	2024-12-31 22:00		2024-11-28 13:59	True

• Call the "agreement/search/meter" API as first OS 38X-EIN-OS-----J. Example from DEV:

{
  "marketParticipantContext": {
    "marketParticipantIdentification": "38X-EIN-OS-----J",
    "marketParticipantRole": "OPEN_SUPPLIER",
    "commodityType": "ELECTRICITY"
  },
  "meterEic": [
    "38ZGO-10000091-V"
  ]
}

• Call the "agreement/search/meter" API as second OS 38X-EIN-ALL----B. Example from DEV:

{
  "marketParticipantContext": {
    "marketParticipantIdentification": "38X-EIN-ALL----B",
    "marketParticipantRole": "OPEN_SUPPLIER",
    "commodityType": "ELECTRICITY"
  },
  "meterEic": [
    "38ZGO-10000091-V"
  ]
}

Expected result

The input doesn't matter. If I query the same API as OPEN_SUPPLIER with the same meterEic, then the system behaves the same (https://confluence.elering.sise/display/EAL/Agreement+requirements#Agreementrequirements-Newagreementrules):

• I can see full data of GRID agreement
• I can see full data of my own SUPPLY agreement
• I can see limited data of other SUPPLY agreements

Actual Result

• As first OS "38X-EIN-OS-----J":
  • I can see full data of GRID agreement - OK
  • I can see full data of my own SUPPLY agreement - OK
  • I can see limited data of other SUPPLY agreements - NOK

Example output:

{
  "meteringPoints": [
    {
      "meterEic": "38ZGO-10000091-V",
      "agreements": [
        {
          "agreementId": "einar-2024-11-28T15:58:59.488549+02:00-EST",
          "meterEic": "38ZGO-10000091-V",
          "agreementType": "GRID",
          "serviceProvider": {
            "serviceProviderEic": "38X-EIN-GO-----0",
            "serviceProviderName": "Einar Grid Operator"
          },
          "customer": {
            "customerEic": "38X-AVP-ZW6700C6",
            "customerName": "EINAR ARRO"
          },
          "preliminaryTerminationFee": false,
          "commodityType": "ELECTRICITY",
          "validFrom": "2024-11-26T22:00:00Z"
        },
        {
          "agreementId": "einar-2024-11-28T15:58:59.488549+02:00-EST",
          "meterEic": "38ZGO-10000091-V",
          "agreementType": "SUPPLY",
          "serviceProvider": {
            "serviceProviderEic": "38X-EIN-OS-----J",
            "serviceProviderName": "Einar Open Supplier"
          },
          "customer": {
            "customerEic": "38X-AVP-ZW6700C6",
            "customerName": "EINAR ARRO"
          },
          "preliminaryTerminationFee": false,
          "commodityType": "ELECTRICITY",
          "validFrom": "2024-11-26T22:00:00Z",
          "validTo": "2024-12-31T22:00:00Z"
        },
        {
          "agreementId": "einar-2024-11-28T15:59:37.674128+02:00-EST",
          "meterEic": "38ZGO-10000091-V",
          "agreementType": "SUPPLY",
          "serviceProvider": {
            "serviceProviderEic": "38X-EIN-ALL----B",
            "serviceProviderName": "Einar All"
          },
          "customer": {
            "customerEic": "38X-AVP-ZW6700C6",
            "customerName": "EINAR ARRO"
          },
          "preliminaryTerminationFee": false,
          "commodityType": "ELECTRICITY",
          "validFrom": "2024-12-31T22:00:00Z"
        }
      ]
    }
  ]
}

• As second OS "38X-EIN-ALL----B":
  • I can see full data of GRID agreement - OK
  • I can see full data of my own SUPPLY agreement - NOK
  • I can see limited data of other SUPPLY agreements - OK

Example output:

{
  "meteringPoints": [
    {
      "meterEic": "38ZGO-10000091-V",
      "agreements": [
        {
          "agreementId": "einar-2024-11-28T15:58:59.488549+02:00-EST",
          "meterEic": "38ZGO-10000091-V",
          "agreementType": "GRID",
          "serviceProvider": {
            "serviceProviderEic": "38X-EIN-GO-----0",
            "serviceProviderName": "Einar Grid Operator"
          },
          "customer": {
            "customerEic": "38X-AVP-ZW6700C6",
            "customerName": "EINAR ARRO"
          },
          "preliminaryTerminationFee": false,
          "commodityType": "ELECTRICITY",
          "validFrom": "2024-11-26T22:00:00Z"
        },
        {
          "meterEic": "38ZGO-10000091-V",
          "agreementType": "SUPPLY",
          "preliminaryTerminationFee": false,
          "commodityType": "ELECTRICITY",
          "validFrom": "2024-11-26T22:00:00Z",
          "validTo": "2024-12-31T22:00:00Z"
        },
        {
          "meterEic": "38ZGO-10000091-V",
          "agreementType": "SUPPLY",
          "preliminaryTerminationFee": false,
          "commodityType": "ELECTRICITY",
          "validFrom": "2024-12-31T22:00:00Z"
        }
      ]
    }
  ]
}

Impact (If known)

Very bad. Marie is not happy :(

Work-a-round

None

[mailimarkvardt]

Current issue resolved, follow-up is #139