Refactor Github Actions

Author: dmohns

.github/workflows/check-generic.yaml

@@ -16,27 +16,25 @@ jobs:
     name: Run editorconfig-checker
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Install editorconfig-checker
-        run: pipx install "editorconfig-checker"
+      - uses: actions/checkout@v4
+
       - name: Run editorconfig-checker
-        run: ec .
+        run: docker run --rm --volume=$PWD:/check mstruebing/editorconfig-checker
 
   markdownlint:
     name: Run markdownlint
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v4
+
       - name: Run markdownlint-cli2
-        uses: DavidAnson/markdownlint-cli2-action@v13
+        uses: DavidAnson/markdownlint-cli2-action@v16
 
   yamllint:
     name: Run yamllint
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v4
+
       - name: Run yamllint
         run: yamllint .

.github/workflows/check.yaml

@@ -1,4 +1,4 @@
-name: Check
+name: Check Code Quality
 
 on:
   push:
@@ -13,18 +13,19 @@ jobs:
     name: Lint ruff
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v4
+
       - name: Install ruff
         run: pipx install ruff
-      - name: Run editorconfig-checker
+
+      - name: Run riff
         run: ruff check .
 
   black:
     name: Lint Black
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v4
+      - uses: actions/checkout@v4
+
       - name: Run Black
         uses: psf/black@stable

.github/workflows/release-pypi.yml renamed to .github/workflows/release-publish-pypi.yml

@@ -1,23 +1,30 @@
-# .github/workflows/ci-cd.yml
-name: PyPI Publish
-on: push
+name: Publish to PyPI
+on:
+  release:
+    types:
+      - published
+  workflow_dispatch:
+
 jobs:
-  pypi-publish:
-    name: Upload release to PyPI
-    if: startsWith(github.ref, 'refs/tags/v')  # On tagged release only
+  release-publish:
     runs-on: ubuntu-latest
+    permissions:
+      contents: read
+      id-token: write
     environment:
       name: release
       url: https://pypi.org/p/openpaygo
-    permissions:
-      id-token: write  # IMPORTANT: this permission is mandatory for trusted publishing
+
     steps:
       - uses: actions/checkout@v4
-      - name: Set up Python
+
+      - name: Setup Python
         uses: actions/setup-python@v4
         with:
           python-version: 3.x
+
       - name: Generate package distribution
         run: python3 setup.py sdist
+
       - name: Publish package distributions to PyPI
         uses: pypa/gh-action-pypi-publish@release/v1