Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conda package #142

Open
antonkulaga opened this issue Apr 15, 2019 · 7 comments
Open

conda package #142

antonkulaga opened this issue Apr 15, 2019 · 7 comments

Comments

@antonkulaga
Copy link

It will be nice to have pyfunctional conda package as mixing conda and pip packages is unsafe.

@EntilZha
Copy link
Owner

Don't know that its unsafe, but having a conda package would be nice. I haven't made a conda package, but I do use conda as an end-user a lot so I'll see if its easy.

@tylergannon
Copy link

I've build a conda package for my own purposes. The biggest hangup is the somewhat antiquated version of dill. Because the conda package for dill 2.7.1 is somewhat old and is pinned to a specific build of python 3.7.3, which produces package resolution errors that can be annoying to untangle. How difficult would it be to update PyFunctional to use a later version of dill?

meta.yaml for PyFunctional:

{% set name = "pyfunctional" %}
{% set version = "1.3.0" %}

package:
  name: "{{ name|lower }}"
  version: "{{ version }}"

source:
  git_url: "https://github.com/EntilZha/PyFunctional.git"
  git_rev: "8e4b630b103d2c52759982522a89fa061691cb77"


build:
  number: 0
  script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed -vv "

requirements:
  host:
    - pip
    - python
  run:
    - dill ==0.2.7.1
    - future ==0.18.2
    - python
    - six ==1.13.0
    - tabulate ==0.8.5

test:
  imports:
    - functional
    - functional.test

about:
  home: "https://github.com/EntilZha/PyFunctional"
  license: "MIT"
  license_family: "MIT"
  license_file: ""
  summary: "Package for creating data pipelines with chain functional programming"
  doc_url: ""
  dev_url: ""

extra:
  recipe-maintainers:
    - your-github-id-here

@EntilZha
Copy link
Owner

I tested making them more flexible and it seems to at least pass tests. That good enough you think?
fdd7120

@tylergannon
Copy link

oi sorry for such a slow response. This works great and I've been using it for the past six weeks since our last interaction.

Not sure about next steps to get this added to conda-forge but I'd love to see it up there. I'm still using homespun builds in our local conda channel.

thanks for the change!
TPG

@tylergannon
Copy link

#147 and pushing a new release can help to put this one to bed.

I've got an up-to-date meta.yaml for the conda package, but the conda-forge requirements stipulate that the source code should be downloadable or at a minimum should point to a tag on Github.

If tag 1.3.1 is made to point to the current HEAD then the below meta.yaml will be correct. I'll go ahead and submit it to conda-forge, unless you'd like to do it yourself.

thanks!
TPG

{% set name = "pyfunctional" %}
{% set version = "1.3.0" %}

package:
  name: "{{ name|lower }}"
  version: "{{ version }}"

source:
  git_url: "https://github.com/EntilZha/PyFunctional.git"
  git_rev: "1.3.1"

build:
  number: 4
  noarch: "python"
  script: "{{ PYTHON }} -m pip install . --no-deps --ignore-installed -vv "

requirements:
  build:
    - dill >=0.2.5
    - future <=1.0.0
    - six <=2.0.0
    - tabulate <=1.0.0
    - python
  run:
    - dill >=0.2.5
    - future <=1.0.0
    - six <=2.0.0
    - tabulate <=1.0.0
    - python

test:
  imports:
    - functional
    - functional.test
  requires:
    - nose
  source_files:
    - functional/test
    - LICENSE.txt
  commands:
    - python -m nose -i "functional/*"

about:
  home: "https://github.com/EntilZha/PyFunctional"
  license: "MIT"
  license_family: "MIT"
  license_file: "LICENSE.txt"
  commands:
    - python -m nose -i "functional/*"

about:
  home: "https://github.com/EntilZha/PyFunctional"
  license: "MIT"
  license_family: "MIT"
  license_file: "LICENSE.txt"
  summary: "Package for creating data pipelines with chain functional programming"
  doc_url: "https://www.pyfunctional.org/"
  dev_url: "https://github.com/EntilZha/PyFunctional"
extra:
  recipe-maintainers:
    - EntilZha
    - tylergannon

@stale
Copy link

stale bot commented Jul 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 9, 2020
@stale stale bot removed the stale label Jul 9, 2020
@antonkulaga
Copy link
Author

So, have you eventually made a conda-package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants