Skip to content

Commit

Permalink
fix(input-message): add missing margin to scale="s", spacing CSS vari…
Browse files Browse the repository at this point in the history
…able has effect (#8592)

**Related Issue:**
#8561 (comment)
## Summary

- Resolve CSS specificity issue that prevented
`--calcite-input-message-spacing-value` from having any effect.
- Add missing margin top to the small scale to align with the Figma
design, where the margin is the same for all scales.
  • Loading branch information
benelan authored Jan 12, 2024
1 parent 7638ec4 commit 49b0a20
Show file tree
Hide file tree
Showing 3 changed files with 58 additions and 76 deletions.
24 changes: 10 additions & 14 deletions packages/calcite-components/src/assets/styles/includes.scss
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,20 @@
// mixin for the container of validation messages displayed below form-associated components
@mixin form-validation-message() {
.validation-container {
padding-block-start: 0.5rem;
display: flex;
flex-direction: column;
align-items: flex-start;
align-self: stretch;
}

:host([scale="m"]) .validation-container,
:host([scale="l"]) .validation-container {
padding-block-start: 0.5rem;
}

:host([scale="s"]) .validation-container {
padding-block-start: 0.25rem;
}
}

// mixin to provide base disabled styles for interactive components
Expand Down Expand Up @@ -122,19 +130,7 @@
}

.x-button {
@apply appearance-none
bg-transparent
border-2
content-center
cursor-pointer
flex
focus-base
items-center
justify-center
m-0
self-center
text-color-3
transition-default;
@apply appearance-none bg-transparent border-2 content-center cursor-pointer flex focus-base items-center justify-center m-0 self-center text-color-3 transition-default;

border-radius: 50%;
border-color: transparent;
Expand Down
Loading

0 comments on commit 49b0a20

Please sign in to comment.