Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rating]: Enhance component's interactivity states #10015

Closed
2 of 9 tasks
DitwanP opened this issue Aug 8, 2024 · 3 comments
Closed
2 of 9 tasks

[Rating]: Enhance component's interactivity states #10015

DitwanP opened this issue Aug 8, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2025-02-25 - Feb ...

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Aug 8, 2024 •
edited
Loading

Check existing issues

Description

Updates the rating's interactive states as part of the larger epic in #9299.

Current state

image

Acceptance Criteria

  • Change outline to fill on hover (This matches the keyboard focus navigation behavior)
  • Update star to brand.hover on hover
  • Update star to brand.press on press

image

Relevant Info

No response

Which Component

rating

Example Use Case

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@DitwanP DitwanP added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. estimate - 3 A day or two of work, likely requires updates to tests. ready for dev Issues ready for development implementation. labels Aug 8, 2024
@DitwanP DitwanP added this to the 2024-12-17 - Dec Release milestone Aug 8, 2024
@DitwanP DitwanP removed the needs triage Planning workflow - pending design/dev review. label Aug 8, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 8, 2024
@github-actions github-actions bot removed this from the 2024-12-17 - Dec Release milestone Aug 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

cc @geospatialem, @brittneytewks

@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 8, 2024
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 8, 2024
@DitwanP DitwanP added this to the 2024-12-17 - Dec Release milestone Aug 8, 2024
@DitwanP DitwanP mentioned this issue Aug 8, 2024
Open
28 tasks
@DitwanP DitwanP removed the Calcite (dev) Issues logged by Calcite developers. label Aug 8, 2024
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Aug 8, 2024
@DitwanP DitwanP added estimate - 2 Small fix or update, may require updates to tests. and removed estimate - 3 A day or two of work, likely requires updates to tests. labels Aug 8, 2024
@aPreciado88 aPreciado88 self-assigned this Feb 5, 2025
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Feb 5, 2025
@monday-com-github monday-com-github bot changed the title [Rating]: Enhance component's interactivity states [Rating]: Enhance component's interactivity states Feb 5, 2025
@aPreciado88 aPreciado88 added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 5, 2025
@aPreciado88 aPreciado88 mentioned this issue Feb 6, 2025
Merged
aPreciado88 added a commit that referenced this issue Feb 20, 2025
@aPreciado88
feat(rating): enhance component's interactivity states (#11469)
17075a7 
**Related Issue:**
[#10015](#10015)

## Summary

- Update star icon to `fill` on `:hover`.
- Update star icon color to `--calcite-color-brand-hover` on `:hover`.
- Update star icon color to `--calcite-color-brand-press` on `:active`.
- Add `--calcite-rating-color-press` css token.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 20, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Feb 20, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor Author

DitwanP commented Feb 21, 2025

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Feb 21, 2025
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88