Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox: Entering filter text when no results are visible will close the combobox #10156

Closed
2 of 6 tasks
paulcpederson opened this issue Aug 24, 2024 · 3 comments
Closed
2 of 6 tasks

Combobox: Entering filter text when no results are visible will close the combobox #10156

paulcpederson opened this issue Aug 24, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Milestone
2.13.1 patch

Comments

@paulcpederson
Copy link
Member

Check existing issues

Actual Behavior

When a single or single-persist combobox has a selected item, and the user enters text leading to no items, the combobox closes suddenly, showing the selected value.

Expected Behavior

If a combobox has a selected item, and the user enters filter text, don't close the combobox. The filterText should remain visible with no results displayed.

Reproduction Sample

https://codepen.io/paulcp/pen/LYKmQQK?editors=100

Reproduction Steps

  1. In a single select combobox with a selected item, type in the combobox until no results are visible
  2. After a short delay, type any key
  3. Notice the combobox collapses
  4. If you click the combobox again, you'll see your text still present, but again any keypress will collapse the menu

Reproduction Version

2.11.1 (latest)

Relevant Info

Something between 2.9.0 and 2.11.0 (which I believe was the next release?) broke this behavior.

Regression?

2.9.0

Priority impact

impact - p2 - want for an upcoming milestone

Impact

This is causing one of our UI's not to work as it's built around the user searching their combobox and it keeps closing on them.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@paulcpederson paulcpederson added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 24, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Aug 24, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Sep 3, 2024
@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone Sep 6, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2024
@jcfranco jcfranco mentioned this issue Sep 26, 2024
Closed
6 tasks
@geospatialem geospatialem added the regression Issues that are caused by changes in a release, but were working before that. label Sep 26, 2024
@geospatialem geospatialem mentioned this issue Sep 26, 2024
Closed
6 tasks
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Oct 7, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Oct 7, 2024
@anveshmekala anveshmekala mentioned this issue Oct 7, 2024
Merged
@anveshmekala
Copy link
Contributor

Combobox closes when no filtered results are shown as per spec #9617.
Agree that filterText should be retained when no results are shown.

cc: @driskull

anveshmekala added a commit that referenced this issue Oct 10, 2024
@anveshmekala
fix(combobox): restores filterText when filtered items are empty (#…
085eb23 
…10498)

**Related Issue:** #10156

## Summary

Restores `filterText` when filtered items are empty.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 10, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 10, 2024
@geospatialem
Copy link
Member

Verified in 2.14.0-next.11, where the component will close per Anvesh's comment above, but filterText is present in the component. Also keeps focus in the component upon closing, making a much better experience for the user:

verify-10156

benelan pushed a commit that referenced this issue Oct 11, 2024
@anveshmekala @benelan
fix(combobox): restores filterText when filtered items are empty (#…
56cb787 
…10498)

**Related Issue:** #10156

## Summary

Restores `filterText` when filtered items are empty.
benelan pushed a commit that referenced this issue Oct 11, 2024
@anveshmekala @benelan
fix(combobox): restores filterText when filtered items are empty (#…
6667c2a 
…10498)

**Related Issue:** #10156

## Summary

Restores `filterText` when filtered items are empty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2.13.1 patch
Development

No branches or pull requests
4 participants
@paulcpederson @geospatialem @DitwanP @anveshmekala