Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox emits change event on programmatic selection #10695

Closed
2 of 5 tasks
driskull opened this issue Nov 5, 2024 · 2 comments
Closed
2 of 5 tasks

Combobox emits change event on programmatic selection #10695

driskull opened this issue Nov 5, 2024 · 2 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@driskull
Copy link
Member

driskull commented Nov 5, 2024

Check existing issues

Actual Behavior

When changing an item to be selected programmatically, the change event is emitted.

Expected Behavior

When changing an item to be selected programmatically, the change event is NOT emitted.

Reproduction Sample

https://codepen.io/driskull/pen/poMOVLE?editors=1000

Reproduction Steps

  1. Open the sample
  2. Notice after 1 second an event is emitted
  3. This is due to a programmatic selection change

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer

@driskull driskull added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 5, 2024
@github-actions github-actions bot added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Nov 5, 2024
@geospatialem geospatialem added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Nov 12, 2024
@DitwanP DitwanP added this to the 2025-06-24 - Jun Milestone milestone Dec 16, 2024
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Dec 16, 2024
@jcfranco
Copy link
Member

This was fixed in 3.0.0 via #10952 (see https://codepen.io/jcfranco/pen/VYwLWRM?editors=1000).

@jcfranco jcfranco added 4 - verified Issues that have been released and confirmed resolved. and removed 0 - new New issues that need assignment. labels Feb 15, 2025
@jcfranco jcfranco self-assigned this Feb 15, 2025
@jcfranco
Copy link
Member

Closing as verified. cc @geospatialem @DitwanP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

4 participants