Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate(action): -pressed tokens in favor of -press + radius for consistency #10831

Closed
2 of 6 tasks
alisonailea opened this issue Nov 21, 2024 · 3 comments
Closed
2 of 6 tasks

deprecate(action): -pressed tokens in favor of -press + radius for consistency #10831

alisonailea opened this issue Nov 21, 2024 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-02-06 - 3.0....

Comments

@alisonailea
Copy link
Contributor

alisonailea commented Nov 21, 2024 •
edited by geospatialem
Loading

Check existing issues

Description

Deprecate -pressed + radius action tokens for consistency across component tokens:

--calcite-action-indicator-color: Specifies the component's indicator color.
--calcite-action-background-color: Specifies the component's background color.
--calcite-action-background-color-hover: Specifies the component's background color when hovered or focused.
--calcite-action-background-color-pressed: [Deprecate] Use --calcite-action-background-color-press. Specifies the component's background color when active.
--calcite-action-background-color-press: Specifies the component's background color when active.
--calcite-action-corner-radius: Specifies the component's corner radius.
--calcite-action-corner-radius-end-end: Specifies the component's corner radius end end.
--calcite-action-corner-radius-end-start: Specifies the component's corner radius end start.
--calcite-action-corner-radius-start-end: Specifies the component's corner radius start end.
--calcite-action-corner-radius-start-start: Specifies the component's corner radius start start.
--calcite-action-text-color: Specifies the component's text color.
--calcite-action-text-color-pressed: [Deprecate] Use --calcite-action-text-color-press. Specifies the component's text color when hovered.
--calcite-action-text-color-press: Specifies the component's text color when hovered.

Proposed advantages

Consistency across component tokens

Which component

action

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@alisonailea alisonailea added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. design-tokens Issues requiring design tokens. labels Nov 21, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Nov 21, 2024
@alisonailea alisonailea mentioned this issue Dec 4, 2024
Merged
@alisonailea alisonailea added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Dec 4, 2024
@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Dec 18, 2024
@DitwanP DitwanP removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 3, 2025
@DitwanP DitwanP added this to the 2025-02-25 - Feb Milestone milestone Jan 3, 2025
@alisonailea
Copy link
Contributor Author

This was completed in Dec. #10986

@alisonailea alisonailea added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 27, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned alisonailea Jan 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added refactor Issues tied to code that needs to be significantly reworked. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Jan 28, 2025
@geospatialem geospatialem changed the title deprecate(action): -pressed tokens in favor of -press deprecate(action): -pressed tokens in favor of -press + radius for consistency Jan 28, 2025
@geospatialem geospatialem removed the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jan 28, 2025
@geospatialem geospatialem added the 4 - verified Issues that have been released and confirmed resolved. label Jan 28, 2025
@geospatialem
Copy link
Member

Updated the scope of the above's title and description linked to #10986.

The above is verified on the internal 3.0 documentation site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

No branches or pull requests
3 participants
@alisonailea @geospatialem @DitwanP