Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Segmented-control-item] update focus ring z-index to use calcite token #11578

Closed
1 of 5 tasks
aPreciado88 opened this issue Feb 18, 2025 · 2 comments
Closed
1 of 5 tasks

[Segmented-control-item] update focus ring z-index to use calcite token #11578

aPreciado88 opened this issue Feb 18, 2025 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. refactor Issues tied to code that needs to be significantly reworked.
Milestone
2025-02-25 - Feb ...

Comments

@aPreciado88
Copy link
Contributor

Description

Update focus ring z-index to use --calcite-z-index.

Proposed Advantages

Code consistency across repo.

Which Component

Segmented-control-item

Relevant Info

Refactor of #10013

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@aPreciado88 aPreciado88 added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked. labels Feb 18, 2025
@aPreciado88 aPreciado88 self-assigned this Feb 18, 2025
@aPreciado88 aPreciado88 added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 18, 2025
@aPreciado88 aPreciado88 mentioned this issue Feb 18, 2025
Merged
aPreciado88 added a commit that referenced this issue Feb 18, 2025
@aPreciado88
refactor(segmented-control-item): use --calcite-z-index css token ins…
3470a98 
…tead of hardcoded value (#11580)

**Related Issue:**
[#11578](#11578)

## Summary
Use `--calcite-z-index` css token instead of hardcoded value to
correctly display focus ring.
@aPreciado88 aPreciado88 added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. needs triage Planning workflow - pending design/dev review. labels Feb 18, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned aPreciado88 Feb 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Feb 19, 2025

🍡 Verified locally on dev

@DitwanP DitwanP closed this as completed Feb 19, 2025
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
3 participants
@geospatialem @DitwanP @aPreciado88