Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip can become bigger than the view #11579

Closed
2 of 6 tasks
sagewall opened this issue Feb 18, 2025 · 2 comments
Closed
2 of 6 tasks

Tooltip can become bigger than the view #11579

sagewall opened this issue Feb 18, 2025 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2025-02-25 - Feb ...

Comments

@sagewall
Copy link

Check existing issues

Actual Behavior

The calcite tooltip can become larger than the view at certain screen sizes

Expected Behavior

The tooltip is always smaller than its view.

Reproduction Sample

https://codepen.io/Matt-Driscoll/pen/pvogjXq?editors=1000

Reproduction Steps

  1. Open codepen
  2. Open devtools and open device toolbar
  3. set responsive size to anything less than 400px
  4. notice that the tooltip goes beyond the view size

Reproduction Version

3.0.2

Relevant Info

No response

Regression?

May be a regression from 2.x

Priority impact

impact - p2 - want for an upcoming milestone

Impact

This was first observed in the Map Viewer application where the tooltips for layers with errors are exceeding the width of the sidebar.

Image

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@sagewall sagewall added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Feb 18, 2025
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Feb 18, 2025
@driskull driskull mentioned this issue Feb 18, 2025
Merged
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. labels Feb 18, 2025
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Feb 18, 2025
driskull added a commit that referenced this issue Feb 19, 2025
@driskull
fix: set floating-ui elements max size set to the view (#11577)
849d04a 
**Related Issue:** #11579

## Summary

- Makes sure floating elements are not larger than `100vw`/`100vh`
- Add screenshot tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Feb 21, 2025

🍠 Verified on 3.1.0-next.13

@DitwanP DitwanP closed this as completed Feb 21, 2025
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2025-02-25 - Feb Milestone
Development

No branches or pull requests
4 participants
@driskull @sagewall @geospatialem @DitwanP