Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit and reconcile bugs and missing colors in Calcite Core Color design tokens #11581

Open
2 of 8 tasks
ashetland opened this issue Feb 18, 2025 · 1 comment
Open
2 of 8 tasks

Audit and reconcile bugs and missing colors in Calcite Core Color design tokens #11581

ashetland opened this issue Feb 18, 2025 · 1 comment
Assignees
@matgalla
Labels
1 - assigned Issues that are assigned to a sprint and a team member. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - design - sm Small design effort; 1-4 days of design work impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@ashetland
Copy link
Contributor

Check existing issues

Actual Behavior

A few bugs have been discovered in the Core Color tokens:

  • v-bb-160 and v-bb-180 have the same value
  • m-ro-090 and m-ro-100 have the same value
  • medium and low saturation colors are missing when compared to the original Calcite Colors repo

Expected Behavior

  • All colors present in Calcite Colors are present in Calcite Core Color design tokens
  • All color values match the original color spec

Reproduction Sample

https://github.com/Esri/calcite-design-system/blob/dev/packages/calcite-design-tokens/src/core/color.json

Reproduction Steps

Compare repro sample with Calcite Colors

Reproduction Version

v3.0

Relevant Info

cc @alisonailea @matgalla @SkyeSeitz

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@ashetland ashetland added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Feb 18, 2025
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Feb 18, 2025
@ashetland ashetland added the design-tokens Issues requiring design tokens. label Feb 18, 2025
@ashetland ashetland changed the title Audit and reconcile bugs and missing colors in Calcite Color Core design tokens Audit and reconcile bugs and missing colors in Calcite Core Color design tokens Feb 18, 2025
@ashetland ashetland closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2025
@ashetland ashetland reopened this Feb 18, 2025
@ashetland
Copy link
Contributor Author

Closed the wrong issue 🤦‍♂️

@ashetland ashetland added design Issues that need design consultation prior to development. p - medium Issue is non core or affecting less that 60% of people using the library estimate - design - sm Small design effort; 1-4 days of design work labels Feb 18, 2025
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matgalla matgalla

Labels
1 - assigned Issues that are assigned to a sprint and a team member. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. estimate - design - sm Small design effort; 1-4 days of design work impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matgalla @ashetland