Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calcite slider histogram is getting clipped #11583

Closed
2 of 6 tasks
ubatsukh opened this issue Feb 18, 2025 · 4 comments
Closed
2 of 6 tasks

Calcite slider histogram is getting clipped #11583

ubatsukh opened this issue Feb 18, 2025 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
3.0.0 Patch - 202...

Comments

@ubatsukh
Copy link

ubatsukh commented Feb 18, 2025 •
edited by jcfranco
Loading

Check existing issues

Actual Behavior

I am creating a new sample that use calcite slider with histogram. It looks like the histogram data is getting clipped. How can I fix that? what am I doing wrong?
Here is my codepen - https://codepen.io/U_B_U/pen/EaxxdbB?editors=1000 (isolated version here)

Notice the flatlines in the following image
Image

@jcfranco confirmed that it is an issue with the internal graph component's masking.

Expected Behavior

The histogram data should not get clipped.

Reproduction Sample

https://codepen.io/U_B_U/pen/EaxxdbB?editors=1000 (isolated version here)

Reproduction Steps

  1. Open this app
  2. Notice the slider with a histogram
  3. Data is being clipped.

Reproduction Version

3.0.2

Relevant Info

No response

Regression?

No response

Priority impact

impact - p1 - need for current milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript
@ubatsukh ubatsukh added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Feb 18, 2025
@github-actions github-actions bot added the impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive label Feb 18, 2025
@jcfranco jcfranco added p - high Issue should be addressed in the current milestone, impacts component or core functionality impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. estimate - 3 A day or two of work, likely requires updates to tests. 2 - in development Issues that are actively being worked on. and removed impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive 0 - new New issues that need assignment. labels Feb 18, 2025
@jcfranco jcfranco self-assigned this Feb 18, 2025
@jcfranco jcfranco removed the needs triage Planning workflow - pending design/dev review. label Feb 18, 2025
@jcfranco jcfranco added this to the 3.0.0 Patch - 2025-02-19 milestone Feb 18, 2025
@jcfranco
Copy link
Member

@jcfranco confirmed that it is an issue with the internal graph component's masking.

Upon closer inspection, it looks like the issue is related to the way the vertical histogram range is computed. The fix is still looks feasible for the upcoming patch.

@jcfranco jcfranco mentioned this issue Feb 19, 2025
Merged
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Feb 19, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Feb 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Feb 19, 2025
@geospatialem
Copy link
Member

Verified for the upcoming patch with 3.1.0-next.10

Image

@ubatsukh
Copy link
Author

Verified for the upcoming patch with 3.1.0-next.10

Image

Oh so beautiful!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. estimate - 3 A day or two of work, likely requires updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
3.0.0 Patch - 2025-02-19
Development

No branches or pull requests
4 participants
@jcfranco @ubatsukh @geospatialem @DitwanP