Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[input-date-picker] - Component does not initialize with value. #8157

Closed
2 of 5 tasks
richiecarmichael opened this issue Nov 10, 2023 · 7 comments
Closed
2 of 5 tasks
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone need more info Issues that are missing information and/or a clear, actionable description. p - low Issue is non core or affecting less that 10% of people using the library

Comments

@richiecarmichael
Copy link

richiecarmichael commented Nov 10, 2023

Check existing issues

Actual Behavior

Component does not initialize ISO date. Only place holder text displayed.

          <calcite-input-date-picker
            value={this._departureDate} // "2023-01-01"
          />

Workaround:

          <calcite-input-date-picker
            valueAsDate={toLocalDate(this._departureDate)}
          />

where:

function toLocalDate(utcDate: string): Date {
  const date = new Date(utcDate);
  return new Date(date.getUTCFullYear(), date.getUTCMonth(), date.getUTCDate());
}

Expected Behavior

Expe

Reproduction Sample

None

Reproduction Steps

None

Reproduction Version

1.10.0

Relevant Info

No response

Regression?

No response

Priority impact

p3 - want for upcoming milestone

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@richiecarmichael richiecarmichael added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels Nov 10, 2023
@github-actions github-actions bot added p3 - want for upcoming milestone calcite-components Issues specific to the @esri/calcite-components package. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. labels Nov 10, 2023
@richiecarmichael richiecarmichael changed the title [calcite-input-date-picker] - Component does not initialize with value. [input-date-picker] - Component does not initialize with value. Nov 10, 2023
@maxpatiiuk
Copy link
Member

@richiecarmichael is this a duplicate of #7014?

@richiecarmichael
Copy link
Author

#7014 is specific to calcite-input-number whereas I'm seeing an issue with calcite-input-date-picker. As @JonUihlein mentioned here the issues may be related. Let's keep this for now. I can assist with verifying/testing when #7014 is fixed.

@geospatialem geospatialem added estimate - 5 A few days of work, definitely requires updates to tests. p - low Issue is non core or affecting less that 10% of people using the library has workaround Issues have a workaround available in the meantime. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Nov 27, 2023
@jcfranco
Copy link
Member

@eriklharper We estimated this at a 5. Do you agree with this or should it be higher/lower?

@geospatialem geospatialem added estimate - 3 A day or two of work, likely requires updates to tests. and removed estimate - 5 A few days of work, definitely requires updates to tests. labels Nov 27, 2023
@geospatialem
Copy link
Member

Estimate updated to reflect additional team expertise, which should include updating the tests to allow sending in a full UTC string.

@geospatialem geospatialem added this to the 2024-08-27 - Aug Release milestone Jan 29, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Jan 29, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@geospatialem geospatialem added the blocked This issue is blocked by another issue. label Jul 29, 2024
@geospatialem
Copy link
Member

Blocked by the effort in PR #8402 to determine if the above is mitigate, or next steps to achieve a solution.

@jcfranco
Copy link
Member

@richiecarmichael Would you mind testing this again? It looks like it was fixed in 3.x (thanks for the simplified repro case from #7014, @maxpatiiuk!).

@jcfranco jcfranco added the need more info Issues that are missing information and/or a clear, actionable description. label Feb 19, 2025
@jcfranco jcfranco removed the blocked This issue is blocked by another issue. label Feb 19, 2025
@richiecarmichael
Copy link
Author

@richiecarmichael Would you mind testing this again? It looks like it was fixed in 3.x (thanks for the simplified repro case from #7014, @maxpatiiuk!).

Yes, just tested with calcite 3.0.2 and it looks good. Thanks! Closing with bonus points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. has workaround Issues have a workaround available in the meantime. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone need more info Issues that are missing information and/or a clear, actionable description. p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Development

No branches or pull requests

4 participants