Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(calcite-flow): visual stuttering if reduce-motion is on #9455

Closed
2 of 6 tasks
maxpatiiuk opened this issue May 29, 2024 · 3 comments
Closed
2 of 6 tasks

bug(calcite-flow): visual stuttering if reduce-motion is on #9455

maxpatiiuk opened this issue May 29, 2024 · 3 comments
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive need more info Issues that are missing information and/or a clear, actionable description. p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@maxpatiiuk
Copy link
Member

Check existing issues

Actual Behavior

(see original issue in JS API: https://devtopia.esri.com/WebGIS/arcgis-js-api/issues/59317)

Slowed down video recording:

Screen.Recording.2024-05-29.at.08.56.07.mov

See more video reproductions in the original issue

Expected Behavior

There should be fewer animations and visual artifacts if reduce motion is enabled

Reproduction Sample

https://next.sites.afd.arcgis.com/javascript/latest/sample-code/sandbox/?sample=popup-multipleelements

Reproduction Steps

  1. Open this sample
  2. Click on any polygon on the map that has more than one feature
  3. Click on the "Select feature" button in the top right - the widget disappears for a moment, before the feature list slides in - this creates needless visual noise
  4. Select any feature - if user has "Reduce motion" enabled, a lot more layout shifts here

Reproduction Version

2.8.4

Relevant Info

See also #5072

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

Causes excessive layout shift in JS API's Popup widget if reduce motion is on

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@maxpatiiuk maxpatiiuk added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 29, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels May 29, 2024
@geospatialem geospatialem added the a11y Issues related to Accessibility fixes or improvements. label May 29, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jun 10, 2024
@geospatialem geospatialem added this to the 2025-01-28 - Jan Release milestone Sep 10, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 10, 2024
@jcfranco
Copy link
Member

This doesn't seem to be reproducible in the latest release. @maxpatiiuk Can you confirm?

@jcfranco jcfranco added the need more info Issues that are missing information and/or a clear, actionable description. label Feb 12, 2025
@geospatialem geospatialem added the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Feb 18, 2025
@maxpatiiuk
Copy link
Member Author

Can confirm the issue is no longer reproducible in the test app provided in the original description in Calcite 3.1

Screen.Recording.2025-02-21.at.16.42.20.mov

There is a tiny layout shift when feature-selection checkboxes appear, but is is barely noticeable. Happens on 2nd+ render too so not caused by lazy loading. Also, this might be caused on JS API side.

Slowed down version with backtracking:

Screen.Recording.2025-02-21.at.16.46.08.mov

Overally, I would consider this a non issue compared to the original issue. Feel free to close as resolved.

@jcfranco
Copy link
Member

@maxpatiiuk Thanks for testing! Closing as resolved per ☝️.

There is a tiny layout shift when feature-selection checkboxes appear, but is is barely noticeable. Happens on 2nd+ render too so not caused by lazy loading. Also, this might be caused on JS API side.

@driskull Could you look at this and help confirm if it's a Maps SDK issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive need more info Issues that are missing information and/or a clear, actionable description. p - low Issue is non core or affecting less that 10% of people using the library spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

3 participants