fix(action-menu): clicking an action menu item should call click event. #8627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
driskull
added
low risk
jcfranco
approved these changes
Jan 19, 2024
| expect(actions[1].getAttribute(activeAttr)).toBe(null); | ||
| expect(actions[2].getAttribute(activeAttr)).toBe(null); | ||
|
|
||
| await page.$eval("calcite-action", (el: HTMLCalciteActionElement) => el.click()); |
There was a problem hiding this comment.
Is there a reason why this is calling click directly vs clicking via the E2E APIs? If so, can you add an explainer comment, otherwise, I'd suggest await page.click("calcite-action"); to simplify.
There was a problem hiding this comment.
Yeah it wasn't triggering the closing of the menu when await page.click("calcite-action") was used.
Merged
geospatialem
pushed a commit
that referenced
this pull request
Jan 24, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>@esri/calcite-components: 2.3.0</summary> ## [2.3.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-01-24) ### Features * **action-bar, action-pad, block, flow-item, panel:** Add `overlayPositioning` prop for built-in menus ([#8633](#8633)) ([714b889](714b889)) * **tab:** Add `--calcite-tab-content-block-padding` to override built-in block-padding ([#8629](#8629)) ([7dae525](7dae525)) ### Bug Fixes * **action-menu:** Clicking an action menu item should call click event. ([#8627](#8627)) ([b12ef6b](b12ef6b)) * **list-item:** Always show hover and pointer styling ([#8622](#8622)) ([4a8a91a](4a8a91a)) </details> <details><summary>@esri/calcite-components-angular: 2.3.0</summary> ## [2.3.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-01-24) ### Miscellaneous Chores * **@esri/calcite-components-angular:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.3.0-next.1 to ^2.3.0 </details> <details><summary>@esri/calcite-components-react: 2.3.0</summary> ## [2.3.0](https://github.com/Esri/calcite-design-system/compare/@esri/[email protected]...@esri/[email protected]) (2024-01-24) ### Miscellaneous Chores * **@esri/calcite-components-react:** Synchronize undefined versions ### Dependencies * The following workspace dependencies were updated * dependencies * @esri/calcite-components bumped from ^2.3.0-next.1 to ^2.3.0 </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8577 #8628
Summary