Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8728 prototype #8730

Closed
wants to merge 5 commits into from
Closed

#8728 prototype #8730

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f450be1
#8728 prototype
driskull Feb 12, 2024
f4aad3a
cleanup
driskull Feb 13, 2024
b08d430
cleanup
driskull Feb 13, 2024
2e5e597
cleanup
driskull Feb 13, 2024
6470be2
cleanup
driskull Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/calcite-components/src/assets/styles/_sortable.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
@mixin sortable-helper-classes() {
.calcite-sortable--chosen,
.calcite-sortable--ghost,
.calcite-sortable--drag {
.calcite-sortable--drag,
.calcite-sortable--fallback {
position: relative;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part fixes the styling error for the dragging element.

overflow: hidden;
}

Expand Down
2 changes: 2 additions & 0 deletions packages/calcite-components/src/components/list-item/list-item.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@
@apply flex flex-col;
--calcite-list-item-icon-color: theme("colors.brand");
--calcite-list-item-spacing-indent: theme("spacing.4");
// uncomment this and it works with `forceFallback: true,`
// padding-block: 10px;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introducing a padding between items seems to fix the dragging when fallback is enabled. Need to figure out why dragging on a web component isnt triggering elements to swap unless there is space between them. cc @jcfranco

}

:host([filter-hidden]) {
Expand Down
Loading
Loading