Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(input-number): deprecate minLength/maxLength props as they have no effect #8734

Merged
merged 2 commits into from
Feb 21, 2024
Merged

docs(input-number): deprecate minLength/maxLength props as they have no effect #8734

merged 2 commits into from
Feb 21, 2024

Conversation

jcfranco
Copy link
Member

Related Issue: N/A

Summary

Deprecates minLength/maxLength since they have no effect on numeric inputs. We can remove them at a future breaking change release.

This stems from #8655 (comment).

@jcfranco jcfranco requested a review from a team as a code owner February 13, 2024 06:30
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 13, 2024
@github-actions github-actions bot added the docs Issues relating to documentation updates only. label Feb 13, 2024
driskull
driskull approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco added the p - low Issue is non core or affecting less that 10% of people using the library label Feb 15, 2024
geospatialem
geospatialem approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🎣

We don't have something similar in place now, but maybe the additional context provides additional support of the "why" for folks.

WDYT about @deprecated Has no effect on the component?

@jcfranco jcfranco added the low risk Issues with low risk for consideration in low risk milestones label Feb 21, 2024
@jcfranco jcfranco merged commit cd6b745 into main Feb 21, 2024
12 of 14 checks passed
@jcfranco jcfranco deleted the jcfranco/deprecate-min-max-length-props-for-number-input branch February 21, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driskull driskull driskull approved these changes

@geospatialem geospatialem geospatialem approved these changes

@DitwanP DitwanP Awaiting requested review from DitwanP

Assignees

@jcfranco jcfranco

Labels
docs Issues relating to documentation updates only. low risk Issues with low risk for consideration in low risk milestones p - low Issue is non core or affecting less that 10% of people using the library skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-02-27 - Feb Maintenance Release
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @driskull @geospatialem