Skip to content

Commit 7533d39

Browse files
raven-aujb-essential
authored andcommitted
autofs: mount point create should honour passed in mode
commit 1e6306652ba18723015d1b4967fe9de55f042499 upstream. The autofs file system mkdir inode operation blindly sets the created directory mode to S_IFDIR | 0555, ingoring the passed in mode, which can cause selinux dac_override denials. But the function also checks if the caller is the daemon (as no-one else should be able to do anything here) so there's no point in not honouring the passed in mode, allowing the daemon to set appropriate mode when required. Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Ian Kent <[email protected]> Cc: <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent e1e13e4 commit 7533d39

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/autofs4/root.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -746,7 +746,7 @@ static int autofs4_dir_mkdir(struct inode *dir, struct dentry *dentry, umode_t m
746746

747747
autofs4_del_active(dentry);
748748

749-
inode = autofs4_get_inode(dir->i_sb, S_IFDIR | 0555);
749+
inode = autofs4_get_inode(dir->i_sb, S_IFDIR | mode);
750750
if (!inode)
751751
return -ENOMEM;
752752
d_add(dentry, inode);

0 commit comments

Comments
 (0)