Skip to content

Commit 7b98f3d

Browse files
vegardjb-essential
authored andcommitted
xfrm: get rid of incorrect WARN
AFAICT this message is just printed whenever input validation fails. This is a normal failure and we shouldn't be dumping the stack over it. Looks like it was originally a printk that was maybe incorrectly upgraded to a WARN: commit 62db5cf Author: stephen hemminger <[email protected]> Date: Wed May 12 06:37:06 2010 +0000 xfrm: add severity to printk Change-Id: Id464bdf25477568c1f1ef5450f3d9db142360323 Cc: Stephen Hemminger <[email protected]> Cc: Steffen Klassert <[email protected]> Signed-off-by: Vegard Nossum <[email protected]> Signed-off-by: Steffen Klassert <[email protected]>
1 parent cc0adf4 commit 7b98f3d

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

net/xfrm/xfrm_user.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2147,7 +2147,7 @@ static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh,
21472147

21482148
err = verify_newpolicy_info(&ua->policy);
21492149
if (err)
2150-
goto bad_policy;
2150+
goto free_state;
21512151

21522152
/* build an XP */
21532153
xp = xfrm_policy_construct(net, &ua->policy, attrs, &err);
@@ -2179,8 +2179,6 @@ static int xfrm_add_acquire(struct sk_buff *skb, struct nlmsghdr *nlh,
21792179

21802180
return 0;
21812181

2182-
bad_policy:
2183-
WARN(1, "BAD policy passed\n");
21842182
free_state:
21852183
kfree(x);
21862184
nomem:

0 commit comments

Comments
 (0)