GH-157 Fix potential leaks (#157)

* Close responses, delete unused methods.

* Close responses. Fix potential leaks.

Author: Jakubk15

src/main/java/com/eternalcode/discordapp/database/DatabaseManager.java

@@ -62,11 +62,6 @@ public void connect() throws SQLException {
         this.connectionSource = new DataSourceConnectionSource(this.hikariDataSource, this.hikariDataSource.getJdbcUrl());
     }
 
-    public void closeConnection() throws Exception {
-        this.hikariDataSource.close();
-        this.connectionSource.close();
-    }
-
     public ConnectionSource getConnectionSource() {
         return this.connectionSource;
     }

src/main/java/com/eternalcode/discordapp/leveling/LevelService.java

@@ -13,8 +13,8 @@ public LevelService(DatabaseManager databaseManager) {
         this.levelRepository = LevelRepositoryImpl.create(databaseManager);
     }
 
-    public CompletableFuture<Level> saveLevel(Level level) {
-        return this.levelRepository.saveLevel(level);
+    public void saveLevel(Level level) {
+        this.levelRepository.saveLevel(level);
     }
 
     public CompletableFuture<Level> find(long id) {

src/main/java/com/eternalcode/discordapp/leveling/experience/ExperienceService.java

@@ -3,7 +3,6 @@
 import com.eternalcode.discordapp.database.DatabaseManager;
 import com.eternalcode.discordapp.observer.ObserverRegistry;
 
-import java.util.List;
 import java.util.concurrent.CompletableFuture;
 import java.util.function.LongSupplier;
 
@@ -17,14 +16,6 @@ public ExperienceService(DatabaseManager databaseManager, ObserverRegistry obser
         this.observerRegistry = observerRegistry;
     }
 
-    public CompletableFuture<Experience> saveExperience(Experience experience, LongSupplier channelId) {
-        return this.experienceRepository.saveExperience(experience).whenComplete((experience1, throwable) -> {
-            if (throwable == null) {
-                this.observerRegistry.publish(new ExperienceChangeEvent(experience1, channelId));
-            }
-        });
-    }
-
     public CompletableFuture<Experience> modifyPoints(long userId, double points, boolean add, LongSupplier channelId) {
         return this.experienceRepository.modifyPoints(userId, points, add).whenComplete((experience, throwable) -> {
             if (throwable == null) {
@@ -33,8 +24,4 @@ public CompletableFuture<Experience> modifyPoints(long userId, double points, bo
         });
     }
 
-    public CompletableFuture<List<Experience>> getTop(int limit, long offset) {
-        return this.experienceRepository.getTop(limit, offset);
-    }
-
 }

src/main/java/com/eternalcode/discordapp/review/GitHubReviewService.java

@@ -6,7 +6,6 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.List;
-import java.util.logging.Level;
 import java.util.logging.Logger;
 import net.dv8tion.jda.api.JDA;
 import net.dv8tion.jda.api.entities.Guild;

src/main/java/com/eternalcode/discordapp/review/GitHubReviewUtil.java

@@ -49,6 +49,8 @@ public static List<String> getReviewers(GitHubPullRequest pullRequest, String gi
             JsonArray requestedReviewers = json.getAsJsonArray("requested_reviewers");
 
             List<String> reviewers = new ArrayList<>();
+            response.close();
+
             for (int i = 0; i < requestedReviewers.size(); i++) {
                 JsonObject reviewer = requestedReviewers.get(i).getAsJsonObject();
                 String reviewerLogin = reviewer.get("login").getAsString();
@@ -78,6 +80,7 @@ public static String getPullRequestTitleFromUrl(GitHubPullRequest pullRequest, S
 
         String string = response.body().string();
         JsonObject jsonObject = JsonParser.parseString(string).getAsJsonObject();
+        response.close();
 
         return jsonObject.get("title").getAsString();
     }
@@ -94,6 +97,8 @@ public static boolean isPullRequestMerged(GitHubPullRequest pullRequest, String
         }
 
         JsonObject json = GSON.fromJson(response.body().string(), JsonObject.class);
+        response.close();
+
         return json.get("merged").getAsBoolean();
     }
 
@@ -110,6 +115,8 @@ public static boolean isPullRequestClosed(GitHubPullRequest pullRequest, String
 
         JsonObject json = GSON.fromJson(response.body().string(), JsonObject.class);
         String state = json.get("state").getAsString();
+        response.close();
+
 
         return "closed".equalsIgnoreCase(state);
     }

src/main/java/com/eternalcode/discordapp/user/UserRepositoryException.java

@@ -18,7 +18,7 @@ protected UserRepositoryImpl(DatabaseManager databaseManager) {
         super(databaseManager, UserWrapper.class);
     }
 
-    public static UserRepository create(DatabaseManager databaseManager) {
+    public static void create(DatabaseManager databaseManager) {
         try {
             TableUtils.createTableIfNotExists(databaseManager.getConnectionSource(), UserWrapper.class);
         }
@@ -27,7 +27,7 @@ public static UserRepository create(DatabaseManager databaseManager) {
             throw new DataAccessException("Failed to create table", sqlException);
         }
 
-        return new UserRepositoryImpl(databaseManager);
+        new UserRepositoryImpl(databaseManager);
     }
 
     @Override

src/main/java/com/eternalcode/discordapp/user/UserRepositoryImpl.java

@@ -78,9 +78,7 @@ Stream<DynamicTest> testValidPullRequestTitles() {
                 "GH-123 This is a valid title",
                 "GH-123 Another valid title"
             )
-            .map(title -> dynamicTest("Valid Title: " + title, () -> {
-                assertTrue(GitHubReviewUtil.isPullRequestTitleValid(title));
-            }));
+            .map(title -> dynamicTest("Valid Title: " + title, () -> assertTrue(GitHubReviewUtil.isPullRequestTitleValid(title))));
     }
 
     @TestFactory
@@ -90,9 +88,7 @@ Stream<DynamicTest> testInvalidPullRequestTitles() {
                 "This is an invalid title",
                 "GH- This title has an invalid number"
             )
-            .map(title -> dynamicTest("Invalid Title: " + title, () -> {
-                assertFalse(GitHubReviewUtil.isPullRequestTitleValid(title));
-            }));
+            .map(title -> dynamicTest("Invalid Title: " + title, () -> assertFalse(GitHubReviewUtil.isPullRequestTitleValid(title))));
     }
 
     @Test