Skip to content

Previews that are built in GHA runners show random commit hashes #1143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
egeakman opened this issue Apr 14, 2025 · 2 comments · May be fixed by #1151
Open

Previews that are built in GHA runners show random commit hashes #1143

egeakman opened this issue Apr 14, 2025 · 2 comments · May be fixed by #1151
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code

Comments

@egeakman
Copy link
Member

egeakman commented Apr 14, 2025 •
edited
Loading

Latest Read the Docs build for #1101:

Image

Latest static server preview build for the same PR:

Image

It is not cache:

Image

I tried to track down the commit that it's showing but it doesn't exist at least in their respective branches.

The content is new though, only the commit hash is wrong.
@egeakman egeakman added bug Something isn't working github_actions Pull requests that update GitHub Actions code labels Apr 14, 2025
@egeakman
Copy link
Member Author

cc @artcz

@artcz
Copy link
Contributor

artcz commented Apr 15, 2025

hmm.. best I can guess right now, it's probably using the detached build commit from the GHA environment. I guess passing the commit hash explicitly (same way we pass the branch name) should solve it.

@artcz artcz linked a pull request Apr 15, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check preview commit hash build EuroPython/website
2 participants
@artcz @egeakman