feat: code improvements

Signed-off-by: Adetokunbo Ige <[email protected]>

Author: Adetokunbo Ige

todo-app/lambda_function/lambda.py

@@ -1,13 +1,15 @@
-import logging,os,uuid
+import logging
+import os
+import uuid
+from datetime import datetime
+from typing import List, Dict, Optional
 
 import boto3
 from fastapi import FastAPI, HTTPException
 from fastapi.middleware.cors import CORSMiddleware
 from mangum import Mangum
 from pydantic import BaseModel
-from typing import List, Dict, Optional
-
-from datetime import datetime
+from botocore.exceptions import ClientError
 
 # Configure logging
 logging.basicConfig(level=logging.DEBUG)
@@ -18,7 +20,7 @@
 # Configure CORS middleware
 app.add_middleware(
     CORSMiddleware,
-    allow_origins=["*"],  # Adjust the allowed origins for your use case
+    allow_origins=["*"],
     allow_credentials=True,
     allow_methods=["*"],
     allow_headers=["*"],
@@ -37,30 +39,30 @@ class TodoItem(BaseModel):
 @app.get("/todos", response_model=List[TodoItem])
 async def get_todos():
     try:
-        # Perform a scan operation on the DynamoDB table
         response = table.scan()
-        # Return the 'Items' from the scan result
         items = response.get("Items", [])
         logging.debug(f"Fetched {len(items)} items from DynamoDB")
         return items
+    except ClientError as e:
+        logging.error(f"DynamoDB ClientError: {e}")
+        raise HTTPException(status_code=500, detail="Error fetching todos")
     except Exception as e:
         logging.error(f"Error getting todos: {e}")
         raise HTTPException(status_code=500, detail="Error fetching todos")
 
 @app.post("/todos", status_code=201, response_model=TodoItem)
 async def create_todo(todo: TodoItem):
     try:
-        # Add the current timestamp to the todo item
         todo_dict = todo.dict()
-        todo_dict["timestamp"] = int(datetime.utcnow().timestamp())  # Unix timestamp in seconds
+        todo_dict["id"] = todo_dict.get("id") or str(uuid.uuid4())
+        todo_dict["timestamp"] = int(datetime.utcnow().timestamp())
 
-        # Add the todo item to DynamoDB
         response = table.put_item(Item=todo_dict)
         logging.debug(f"DynamoDB put_item response: {response}")
-        return todo_dict  # Return the updated item with the timestamp
-    except boto3.exceptions.Boto3Error as boto_error:
-        logging.error(f"Boto3Error: {boto_error}")
-        raise HTTPException(status_code=500, detail=f"DynamoDB Error: {str(boto_error)}")
+        return todo_dict
+    except ClientError as boto_error:
+        logging.error(f"ClientError: {boto_error}")
+        raise HTTPException(status_code=500, detail="DynamoDB Error")
     except Exception as e:
         logging.error(f"Unexpected error creating todo: {e}")
         raise HTTPException(status_code=500, detail="Error creating todo")
@@ -70,9 +72,8 @@ async def update_todo(id: str, todo: Dict[str, str]):
     if "text" not in todo:
         raise HTTPException(status_code=400, detail="Missing 'text' in request body")
     try:
-        # Update the todo item in DynamoDB
         response = table.update_item(
-            Key={"id": id},  # Ensure id is passed as a string
+            Key={"id": id},
             UpdateExpression="SET #t = :t",
             ExpressionAttributeNames={"#t": "text"},
             ExpressionAttributeValues={":t": todo["text"]},
@@ -83,20 +84,25 @@ async def update_todo(id: str, todo: Dict[str, str]):
             raise HTTPException(status_code=404, detail="Todo not found")
         logging.debug(f"Updated item: {updated_todo}")
         return updated_todo
+    except ClientError as e:
+        logging.error(f"ClientError updating todo: {e}")
+        raise HTTPException(status_code=500, detail="Error updating todo")
     except Exception as e:
         logging.error(f"Error updating todo: {e}")
         raise HTTPException(status_code=500, detail="Error updating todo")
 
 @app.delete("/todos/{id}", status_code=204)
 async def delete_todo(id: str):
     try:
-        # Delete the todo item from DynamoDB
-        response = table.delete_item(Key={"id": id})  # Ensure id is passed as a string
+        response = table.delete_item(Key={"id": id})
         status_code = response.get("ResponseMetadata", {}).get("HTTPStatusCode")
         if status_code != 200:
             raise HTTPException(status_code=404, detail="Todo not found")
         logging.debug(f"Deleted item with id: {id}")
-        return {"detail": "Todo deleted successfully"}
+        return
+    except ClientError as e:
+        logging.error(f"ClientError deleting todo: {e}")
+        raise HTTPException(status_code=500, detail="Error deleting todo")
     except Exception as e:
         logging.error(f"Error deleting todo: {e}")
         raise HTTPException(status_code=500, detail="Error deleting todo")
@@ -105,7 +111,6 @@ async def delete_todo(id: str):
 async def health():
     try:
         logging.debug("Health check initiated")
-        # Simple check to see if everything is working
         return {"message": "Everything looks good!"}
     except Exception as e:
         logging.error(f"Health check error: {e}")
@@ -115,4 +120,4 @@ async def health():
 def handler(event, context):
     logging.info(f"Received event: {event}")
     mangum_handler = Mangum(app)
-    return mangum_handler(event, context)
+    return mangum_handler(event, context)