Skip to content

Commit f0b1489

Browse files
committed
Fixes after coderabbitai
1 parent a04e12a commit f0b1489

File tree

2 files changed

+11
-13
lines changed

2 files changed

+11
-13
lines changed

src/main/java/com/faforever/client/preferences/MatchmakerPrefs.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ public class MatchmakerPrefs {
1919

2020
private final ObservableSet<Integer> selectedQueueIds = observableSet();
2121

22-
2322
public ObservableList<Faction> getFactions() {
2423
return factions;
2524
}

src/main/java/com/faforever/client/teammatchmaking/TeamMatchmakingService.java

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,14 @@ public void afterPropertiesSet() throws Exception {
260260

261261
partyMembersNotReady.bind(playersInGame.emptyProperty().map(empty -> !empty));
262262

263-
queues.forEach(queue -> listenToSelectedChange(queue));
263+
gameService.getGames().subscribe(() -> queues.forEach(this::updateMatchmakerGameCount));
264+
265+
queues.forEach(queue -> {
266+
if (queue.isSelected()) {
267+
matchmakerPrefs.getSelectedQueueIds().add(queue.getId());
268+
}
269+
listenToSelectedChange(queue);
270+
});
264271
queues.addListener((Change<? extends MatchmakerQueueInfo> change) -> {
265272
while (change.next()) {
266273
if (change.wasAdded()) {
@@ -457,22 +464,15 @@ private void updateMatchmakerGameCount(MatchmakerQueueInfo matchmakerQueue) {
457464
private Mono<MatchmakerQueueInfo> getQueueFromApi(MatchmakerInfo.MatchmakerQueue matchmakerQueue) {
458465
ElideNavigatorOnCollection<MatchmakerQueue> navigator = ElideNavigator.of(MatchmakerQueue.class)
459466
.collection()
460-
.setFilter(qBuilder().string("technicalName")
461-
.eq(matchmakerQueue.getName()));
462-
return fafApiAccessor.getMany(navigator)
463-
.next()
467+
.setFilter(qBuilder().string("technicalName").eq(matchmakerQueue.getName()));
468+
return fafApiAccessor.getMany(navigator).next()
464469
.map(matchmakerMapper::map)
465470
.map(queue -> matchmakerMapper.update(matchmakerQueue, queue))
466471
.doOnNext(queue -> {
467472
boolean isSelected = !matchmakerPrefs.getUnselectedQueueIds().contains(queue.getId());
468473
queue.setSelected(isSelected);
469474
})
470-
.doOnNext(queue -> {
471-
gameService.getGames().subscribe(() -> updateMatchmakerGameCount(queue));
472-
})
473-
.doOnNext(queue -> {
474-
nameToQueue.put(queue.getTechnicalName(), queue);
475-
});
475+
.doOnNext(queue -> nameToQueue.put(queue.getTechnicalName(), queue));
476476
}
477477

478478
public CompletableFuture<Boolean> joinQueues() {
@@ -495,7 +495,6 @@ public CompletableFuture<Boolean> joinQueues() {
495495

496496
validQueues.forEach(queue -> {
497497
queue.setSelected(true);
498-
matchmakerPrefs.getSelectedQueueIds().add(queue.getId());
499498
});
500499

501500
return featuredModService.updateFeaturedModToLatest(FAF.getTechnicalName(), false)

0 commit comments

Comments
 (0)