-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dockerfiles should use pyproject.toml to install optional dependencies #3135
Comments
pip-tools seems to have support for creating |
How about we slim down the images and let the CI runner install Python optional dependencies, documentation dependencies, etc. This makes testing, pinning and un-pinning versions much easier |
👍👍👍 The only possible downside I see is that, if pinning was required, one would have to do that several times, for instance:
|
@francesco-ballarin The petsc4py, mpi4py and numpy and the other heavy packages will be built inside the Dockerfile as they are now. |
Hey, I am still new to open-source contributions and would like to help with this issue. I have created the pull request #3618 which adds a workflow that installs the Python dependencies with the Regarding the slim down of the Docker images, I wanted to ask which dependencies are all optional and should be moved to |
Describe new/missing feature
We currently attempt to include optional dependencies in our
pyproject.toml
filehttps://github.com/FEniCS/dolfinx/blob/main/python/pyproject.toml
But this remains untested as the CI image builds manually type optional dependencies
https://github.com/FEniCS/dolfinx/blob/main/docker/Dockerfile.test-env#L156
There is some discussion of this issue here with respect to adding e.g.
--only-deps
option topip install
: pypa/pip#11440Suggested user interface
Not applicable.
The text was updated successfully, but these errors were encountered: