Merge branch 'develop'

Author: FFMG

monitor/ActionMonitor/Action.cpp

@@ -1,50 +1,55 @@
-// Action.cpp: implementation of the Action class.
+//This file is part of Myoddweb.Piger.
 //
-//////////////////////////////////////////////////////////////////////
-
+//    Myoddweb.Piger is free software: you can redistribute it and/or modify
+//    it under the terms of the GNU General Public License as published by
+//    the Free Software Foundation, either version 3 of the License, or
+//    (at your option) any later version.
+//
+//    Myoddweb.Piger is distributed in the hope that it will be useful,
+//    but WITHOUT ANY WARRANTY; without even the implied warranty of
+//    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.See the
+//    GNU General Public License for more details.
+//
+//    You should have received a copy of the GNU General Public License
+//    along with Myoddweb.Piger.  If not, see<https://www.gnu.org/licenses/gpl-3.0.en.html>.
 #include "stdafx.h"
 #include "Action.h"
 #include "ActionMonitor.h"
 #include "activeaction.h"
 #include "activepythonaction.h"
-#include "activeluaaction.h"
-#include "activepluginaction.h"
+#include "ActiveVirtualMachineAction.h"
 #include "activedefaultaction.h"
 #include "activebatchaction.h"
 #include "activecmdaction.h"
 #include "activecomaction.h"
 #include "activeexeaction.h"
-#include "activeshellAction.h"
-
-#include "os/os.h"
-#include "ActivePowershellAction.h"
-#include "ActiveCsAction.h"
 
 /**
  * \brief Constructor
+ * \param application the application manager.
  */
-Action::Action()
+Action::Action(IApplication& application) :
+  _application(application)
 {
   Reset();
 }
 
 /**
  * \brief Constructor
+ * \param application the application manager.
  * \param szCommand the name of the action, (the the user will enter)
  * \param szPath the full path of the action that we will execute.
  * \return none
  */
-Action::Action(const std::wstring& szCommand, const std::wstring& szPath )
+Action::Action(IApplication& application, const std::wstring& szCommand, const std::wstring& szPath ) :
+  Action(application)
 {
   if(szCommand.length() == 0 )
   {
     //  we cannot have nullptr commands.
     throw -1;
   }
 
-  //  reset everything
-  Reset();
-
   // set the command and make sure it is valid.
   _szCommand = szCommand;
   myodd::strings::Trim(_szCommand);
@@ -79,9 +84,9 @@ Action::Action(const std::wstring& szCommand, const std::wstring& szPath )
  * @version 0.1
  * @return none
  */
-Action::Action( const Action&action)
+Action::Action( const Action&action) : 
+  Action( action._application )
 {
-  Reset();
   *this = action;
 }
 
@@ -121,12 +126,13 @@ void Action::SetCommandPath(const std::wstring& szPath )
 
 /**
  * \brief Run the command, we take into account the current selection and command parameters given.
+ * \param virtualMachines the virtual machine.
  * \param pWnd the last foreground window.
  * \param szCommandLine the command line argument.
  * \param isPrivileged if we need administrator privilege to run this.
  * \return BOOL true.
  */
-ActiveAction* Action::CreateActiveAction(IVirtualMachines& virtualMachines, CWnd* pWnd, const std::wstring& szCommandLine, const bool isPrivileged) const
+IActiveAction* Action::CreateActiveAction(IVirtualMachines& virtualMachines, CWnd* pWnd, const std::wstring& szCommandLine, const bool isPrivileged) const
 {
   //  not sure how to do that...
   if ( Len() == 0)
@@ -141,7 +147,7 @@ ActiveAction* Action::CreateActiveAction(IVirtualMachines& virtualMachines, CWnd
   //  if we are here then we are going to load a user command
   //
   //  If the user did not pass any arguments/command line then we must get them from the clipboard.
-  ActiveAction* aa;
+  IActiveAction* aa;
   if( szCommandLine.length() == 0 )
   {
     aa = CreateActiveActionWithNoCommandLine( virtualMachines, pWnd, isPrivileged);
@@ -154,17 +160,17 @@ ActiveAction* Action::CreateActiveAction(IVirtualMachines& virtualMachines, CWnd
 
   // now that we are back from calling the plugin, restore the keyboard state.
   hook_RejectKeyboad( bThen );
-
   return aa;
 }
 
 /**
  * \brief Try and do it when we have no command line
+ * \param virtualMachines
  * \param pWnd the last foreground window.
  * \param isPrivileged if this action is privileged or not.
  * \return bool success or not.
  */
-ActiveAction* Action::CreateActiveActionWithNoCommandLine(IVirtualMachines& virtualMachines, CWnd* pWnd, const bool isPrivileged ) const
+IActiveAction* Action::CreateActiveActionWithNoCommandLine(IVirtualMachines& virtualMachines, CWnd* pWnd, const bool isPrivileged ) const
 {
   //  the command line we will try and make.
   std::wstring szCommandLine = L"";
@@ -183,7 +189,7 @@ ActiveAction* Action::CreateActiveActionWithNoCommandLine(IVirtualMachines& virt
     //  there will probably only be a conflict with explorer, (of any flavor)
     //  that could copy text and/or file names.
     //
-    const auto foregroundWnd = CActionMonitorApp::GetLastForegroundWindow();
+    const auto foregroundWnd = _application.GetLastForegroundWindow();
     Clipboard clipboard(foregroundWnd, maxClipboardMemory );
 
     // any other values are rejected, (bitmaps and so on).
@@ -256,118 +262,16 @@ const std::wstring& Action::Command() const
   return _szCommand;
 }
 
-/**
- * \brief Execute a file.
- *        We will expend all the environment variables as needed.
- * \param argv [0] the file path, [1] the arguments to launch with, (optional).
- * \param isPrivileged if we need administrator privilege to run this.
- * \param hProcess if this value is not nullptr, we will return the handle of the started process.
- *               it is then up to the calling application to close this handle when done with it...
- * \return bool true|false success or not.
- */
-bool Action::Execute(const std::vector<std::wstring>& argv, const bool isPrivileged, HANDLE* hProcess)
-{
-  // get the number of arguments.
-  auto argc = argv.size();
-
-  // sanity check
-  if( argc < 1 || argc > 2 )
-  {
-    ASSERT ( 0 ); //  wrong number of arguments.
-    return false;
-  }
-
-  LPTSTR argvModule = nullptr;
-  LPTSTR argvCmd = nullptr;
-
-  // get the module name, (what we are running).
-  // Expand the values that might have been passed.
-  if( !myodd::files::ExpandEnvironment( argv[ 0 ].c_str(), argvModule ) )
-  {
-    myodd::log::LogError(_T("Could not execute statement: Unable to expand command line '%s'"), argv[0].c_str());
-    return false;
-  }
-
-  // But we might also have a command line item.
-  if( 2 == argc )
-  {
-    // Expand the values that might have been passed.
-    if( !myodd::files::ExpandEnvironment( argv[ 1 ].c_str(), argvCmd ) )
-    {
-      myodd::log::LogError(_T("Could not execute statement: Unable to expand arguments '%s'"), argv[1].c_str());
-      delete [] argvModule;
-      return false;
-    }
-  }
-
-  //
-  // ShellExecuteEx
-  // https://msdn.microsoft.com/en-us/library/windows/desktop/bb759784(v=vs.85).aspx 
-  //
-  SHELLEXECUTEINFO sei = {};
-  sei.cbSize = sizeof(sei);     // in, required, sizeof of this structure
-  sei.fMask = SEE_MASK_DEFAULT; // in, SEE_MASK_XXX values
-  sei.hwnd = nullptr;           // in, optional
-  sei.lpFile = argvModule;      // in, either this value or lpIDList must be specified
-  sei.lpParameters = argvCmd;   // in, optional
-  sei.lpDirectory = nullptr;    // in, optional
-  sei.nShow = SW_NORMAL;        // in, required
-  //sei.hInstApp;               // out when SEE_MASK_NOCLOSEPROCESS is specified
-  //sei.lpIDList;               // in, valid when SEE_MASK_IDLIST is specified, PCIDLIST_ABSOLUTE, for use with SEE_MASK_IDLIST & SEE_MASK_INVOKEIDLIST
-  //sei.lpClass;                // in, valid when SEE_MASK_CLASSNAME is specified
-  //sei.hkeyClass;              // in, valid when SEE_MASK_CLASSKEY is specified
-  //sei.dwHotKey;               // in, valid when SEE_MASK_HOTKEY is specified
-  if (isPrivileged == true && !myodd::os::IsElevated() )
-  {
-    sei.lpVerb = _T("runas"); // in, optional when unspecified the default verb is choosen
-  }
-  else
-  {
-    //  launch as a normal file.
-    sei.lpVerb = _T("open");  // in, optional when unspecified the default verb is choosen
-  }
-
-  // did the user pass a handle?
-  // if they did then they want to take ownership of the process and close the handle.
-  if (hProcess != nullptr )
-  {
-    sei.fMask = SEE_MASK_NOCLOSEPROCESS; // in, SEE_MASK_XXX values
-  }
-
-  // Assume error
-  auto result = false;
-  if (!ShellExecuteEx(&sei))
-  {
-    myodd::log::LogError(_T("Could not execute statement: could not execute '%s'"), argvModule);
-    myodd::log::LogError(_T("Could not execute statement: Last error '%d'"), ::GetLastError());
-  }
-  else
-  {
-    result = true;
-    if (hProcess != nullptr)
-    {
-      // return the handle.
-      *hProcess = sei.hProcess;
-    }
-  }
-
-  // clean up the expended variable.
-  delete [] argvCmd;
-  delete [] argvModule;
-
-  // return what we found
-  return result;
-}
-
 /**
  * \brief Launch a single action with all the command line arguments.
  * TODO : The API calls ignore the values been passed to them, so we should first check that we have all the values.
- * \param pWnd the last forground window.
+ * \param virtualMachines the virtual machines manager.
+ * \param pWnd the last foreground window.
  * \param szCommandLine the command and the arguments we are launching this file with.
  * \param isPrivileged if we need administrator privilege to run this.
  * \return TRUE|FALSE success or not.
  */
-ActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines, CWnd* pWnd, const std::wstring& szCommandLine, const bool isPrivileged) const
+IActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines, CWnd* pWnd, const std::wstring& szCommandLine, const bool isPrivileged) const
 {
   // sanity check
   if (0 == _szFile.length())
@@ -383,7 +287,8 @@ ActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines
   //
   if (LuaVirtualMachine::IsExt(_szFile ))
   {
-    auto ala = new ActiveLuaAction(*this, virtualMachines, hTopHWnd, szCommandLine, isPrivileged);
+    auto& virtualMachine = virtualMachines.Get(IVirtualMachines::Type::Lua);
+    auto ala = new ActiveVirtualMachineAction(_application, *this, virtualMachine, hTopHWnd, szCommandLine, isPrivileged);
     if (ala->Initialize())
     {
       return ala;
@@ -399,7 +304,8 @@ ActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines
   //
   if (PythonVirtualMachine::IsExt(_szFile))
   {
-    auto apa = new ActivePythonAction(*this, virtualMachines, hTopHWnd, szCommandLine, isPrivileged);
+    auto& virtualMachine = virtualMachines.Get(IVirtualMachines::Type::Python);
+    auto apa = new ActivePythonAction(_application, *this, virtualMachine, hTopHWnd, szCommandLine, isPrivileged);
     if(apa->Initialize() )
     { 
       return apa;
@@ -415,7 +321,8 @@ ActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines
   //
   if (PowershellVirtualMachine::IsExt(_szFile))
   {
-    auto apa = new ActivePowershellAction(*this, virtualMachines, hTopHWnd, szCommandLine, isPrivileged);
+    auto& virtualMachine = virtualMachines.Get(IVirtualMachines::Type::Powershell);
+    auto apa = new ActiveVirtualMachineAction(_application, *this, virtualMachine, hTopHWnd, szCommandLine, isPrivileged);
     if (apa->Initialize())
     {
       return apa;
@@ -431,7 +338,8 @@ ActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines
   //
   if (ShellVirtualMachine::IsExt(_szFile))
   {
-    auto asa = new ActiveShellAction(*this, virtualMachines, hTopHWnd, szCommandLine, isPrivileged);
+    auto& virtualMachine = virtualMachines.Get(IVirtualMachines::Type::Shell);
+    auto asa = new ActiveVirtualMachineAction(_application, *this, virtualMachine, hTopHWnd, szCommandLine, isPrivileged);
     if (asa->Initialize())
     {
       return asa;
@@ -447,7 +355,8 @@ ActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines
   //
   if (CsVirtualMachine::IsExt(_szFile))
   {
-    auto acsa = new ActiveCsAction(*this, virtualMachines, hTopHWnd, szCommandLine, isPrivileged);
+    auto& virtualMachine = virtualMachines.Get(IVirtualMachines::Type::CSharp);
+    auto acsa = new ActiveVirtualMachineAction(_application, *this, virtualMachine, hTopHWnd, szCommandLine, isPrivileged);
     if (acsa->Initialize())
     {
       return acsa;
@@ -463,7 +372,8 @@ ActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines
   //
   if (PluginVirtualMachine::IsExt(_szFile))
   {
-    auto apa = new ActivePluginAction(*this, virtualMachines, hTopHWnd, szCommandLine, isPrivileged);
+    auto& virtualMachine = virtualMachines.Get(IVirtualMachines::Type::LegacyPlugin);
+    auto apa = new ActiveVirtualMachineAction(_application, *this, virtualMachine, hTopHWnd, szCommandLine, isPrivileged);
     if (apa->Initialize())
     {
       return apa;
@@ -477,21 +387,21 @@ ActiveAction* Action::CreateActiveActionDirect(IVirtualMachines& virtualMachines
   // Batch files...
   if( myodd::files::IsExtension (_szFile, _T("bat")))
   {
-    return new ActiveBatchAction(*this, virtualMachines, hTopHWnd, szCommandLine );
+    return new ActiveBatchAction(_application, *this, hTopHWnd, szCommandLine );
   }
   if (myodd::files::IsExtension(_szFile, _T("cmd")))
   {
-    return new ActiveCmdAction(*this, virtualMachines, hTopHWnd, szCommandLine);
+    return new ActiveCmdAction(_application, *this, hTopHWnd, szCommandLine);
   }
   if (myodd::files::IsExtension(_szFile, _T("com")))
   {
-    return new ActiveComAction(*this, virtualMachines, hTopHWnd, szCommandLine);
+    return new ActiveComAction(_application, *this, hTopHWnd, szCommandLine);
   }
   if (myodd::files::IsExtension(_szFile, _T("exe")))
   {
-    return new ActiveExeAction(*this, virtualMachines, hTopHWnd, szCommandLine, isPrivileged);
+    return new ActiveExeAction(_application, *this, hTopHWnd, szCommandLine, isPrivileged);
   }
 
   // run the default action.
-  return new ActiveDefaultAction( *this, virtualMachines, hTopHWnd, szCommandLine, isPrivileged );
+  return new ActiveDefaultAction(_application, *this, hTopHWnd, szCommandLine, isPrivileged );
 }