From f31a89b51c29b9f1602bfa91b2d86bf01b1ab6eb Mon Sep 17 00:00:00 2001 From: LTS-FFXIV <127939494+LTS-FFXIV@users.noreply.github.com> Date: Mon, 22 Jul 2024 13:43:08 -0500 Subject: [PATCH] Nuget bump, ranged viper GCD fix, and GND fix attempt --- BasicRotations/Melee/VPR_Default.cs | 1 + BasicRotations/RebornRotations.csproj | 2 +- BasicRotations/Tank/GNB_Default.cs | 12 +++--------- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/BasicRotations/Melee/VPR_Default.cs b/BasicRotations/Melee/VPR_Default.cs index 83d783e..6d603c8 100644 --- a/BasicRotations/Melee/VPR_Default.cs +++ b/BasicRotations/Melee/VPR_Default.cs @@ -245,6 +245,7 @@ protected override bool GeneralGCD(out IAction? act) if (UnCoilCoil.CanUse(out act, skipComboCheck: true, skipCastingCheck: true, skipAoeCheck: true, skipStatusProvideCheck: true)) return true; } + if (WrithingSnapPvE.CanUse(out act)) return true; return base.GeneralGCD(out act); } diff --git a/BasicRotations/RebornRotations.csproj b/BasicRotations/RebornRotations.csproj index 5024d44..b97d7a1 100644 --- a/BasicRotations/RebornRotations.csproj +++ b/BasicRotations/RebornRotations.csproj @@ -9,7 +9,7 @@ - + diff --git a/BasicRotations/Tank/GNB_Default.cs b/BasicRotations/Tank/GNB_Default.cs index 84b6bfa..e921f4e 100644 --- a/BasicRotations/Tank/GNB_Default.cs +++ b/BasicRotations/Tank/GNB_Default.cs @@ -96,17 +96,11 @@ protected override bool AttackAbility(IAction nextGCD, out IAction? act) #region GCD Logic protected override bool GeneralGCD(out IAction? act) { - bool IsReadyToReign = (Player.HasStatus(true, StatusID.ReadyToReign)); bool areDDTargetsInRange = AllHostileTargets.Any(hostile => hostile.DistanceToPlayer() < 4.5f); - if (IsLastGCD(true, NobleBloodPvE) && LionHeartPvE.CanUse(out act, skipStatusProvideCheck: true, skipComboCheck: true, skipAoeCheck: true)) return true; - - if (IsLastGCD(true, ReignOfBeastsPvE) && NobleBloodPvE.CanUse(out act, skipStatusProvideCheck: true, skipComboCheck: true, skipAoeCheck: true)) return true; - - if (IsReadyToReign) - { - if (ReignOfBeastsPvE.CanUse(out act, skipAoeCheck: true)) return true; - } + if (LionHeartPvE.CanUse(out act)) return true; + if (NobleBloodPvE.CanUse(out act)) return true; + if (ReignOfBeastsPvE.CanUse(out act)) return true; if (FatedCirclePvE.CanUse(out act)) return true;