diff --git a/.gitignore b/.gitignore index 1b74810..f152ed5 100644 --- a/.gitignore +++ b/.gitignore @@ -2,3 +2,9 @@ build/ run/ .gradle/ + +bin/ +*.launch +*.classpath +*.project +.settings diff --git a/src/main/java/com/martmists/libgamerule/Gamerule.java b/src/main/java/com/martmists/libgamerule/Gamerule.java index cf49d7f..1ecb1e5 100644 --- a/src/main/java/com/martmists/libgamerule/Gamerule.java +++ b/src/main/java/com/martmists/libgamerule/Gamerule.java @@ -22,10 +22,10 @@ import java.util.function.Supplier; public class Gamerule implements ModInitializer { - public static Supplier SERVER_SUPPLIER; + static Supplier SERVER_SUPPLIER; public static boolean dirty = false; - public static CommandDispatcher DISPATCHER; - public static List> unregistered = new ArrayList<>(); + private static CommandDispatcher DISPATCHER; + public static final List> unregistered = new ArrayList<>(); public static > GameRules.RuleKey register(String name, GameRules.RuleType type) { dirty = true; @@ -51,8 +51,7 @@ public static & ValueGetter, V> V get(GameRules. } public static > GameRules.RuleType createRuleType(Supplier> argumentType, Function, T> factory) { - return createRuleType(argumentType, factory, (s, r) -> { - }); + return createRuleType(argumentType, factory, (s, r) -> {}); } public static > GameRules.RuleType createRuleType(Supplier> argumentType, Function, T> factory, BiConsumer notifier) { diff --git a/src/main/java/com/martmists/libgamerule/arguments/EnumArgumentType.java b/src/main/java/com/martmists/libgamerule/arguments/EnumArgumentType.java index 6aefb29..e932789 100644 --- a/src/main/java/com/martmists/libgamerule/arguments/EnumArgumentType.java +++ b/src/main/java/com/martmists/libgamerule/arguments/EnumArgumentType.java @@ -16,7 +16,7 @@ import java.util.stream.Collectors; public class EnumArgumentType> implements ArgumentType { - Class clazz; + private Class clazz; public EnumArgumentType(Class enumClass) { this.clazz = enumClass; diff --git a/src/main/java/com/martmists/libgamerule/mixin/GameRuleCommandAccessor.java b/src/main/java/com/martmists/libgamerule/mixin/GameRuleCommandAccessor.java index 5eef973..26f9c35 100644 --- a/src/main/java/com/martmists/libgamerule/mixin/GameRuleCommandAccessor.java +++ b/src/main/java/com/martmists/libgamerule/mixin/GameRuleCommandAccessor.java @@ -9,14 +9,14 @@ @Mixin(GameRuleCommand.class) public interface GameRuleCommandAccessor { + /** @noinspection PublicStaticMixinMember */ @Invoker - @SuppressWarnings("PublicStaticMixinMember") static > int invokeExecuteSet(CommandContext commandContext, GameRules.RuleKey ruleKey) { throw new AssertionError("This shouldn't happen!"); } + /** @noinspection PublicStaticMixinMember */ @Invoker - @SuppressWarnings("PublicStaticMixinMember") static > int invokeExecuteQuery(ServerCommandSource serverCommandSource, GameRules.RuleKey ruleKey) { throw new AssertionError("This shouldn't happen!"); } diff --git a/src/main/java/com/martmists/libgamerule/mixin/GameRulesAccessor.java b/src/main/java/com/martmists/libgamerule/mixin/GameRulesAccessor.java index 4f2163c..dc589a3 100644 --- a/src/main/java/com/martmists/libgamerule/mixin/GameRulesAccessor.java +++ b/src/main/java/com/martmists/libgamerule/mixin/GameRulesAccessor.java @@ -6,8 +6,8 @@ @Mixin(GameRules.class) public interface GameRulesAccessor { + /** @noinspection PublicStaticMixinMember */ @Invoker - @SuppressWarnings("PublicStaticMixinMember") static > GameRules.RuleKey invokeRegister(String name, GameRules.RuleType type) { throw new AssertionError("This shouldn't happen!"); } diff --git a/src/main/java/com/martmists/libgamerule/mixin/RuleTypeAccessor.java b/src/main/java/com/martmists/libgamerule/mixin/RuleTypeAccessor.java index 23f4ca8..59a4261 100644 --- a/src/main/java/com/martmists/libgamerule/mixin/RuleTypeAccessor.java +++ b/src/main/java/com/martmists/libgamerule/mixin/RuleTypeAccessor.java @@ -1,6 +1,8 @@ package com.martmists.libgamerule.mixin; import com.mojang.brigadier.arguments.ArgumentType; + +import net.minecraft.server.MinecraftServer; import net.minecraft.world.GameRules; import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.gen.Invoker; @@ -11,9 +13,9 @@ @Mixin(GameRules.RuleType.class) public interface RuleTypeAccessor { + /** @noinspection PublicStaticMixinMember */ @Invoker("") - @SuppressWarnings("PublicStaticMixinMember") - static GameRules.RuleType invokeNew(Supplier> argumentType, Function factory, BiConsumer notifier) { + static > GameRules.RuleType invokeNew(Supplier> argumentType, Function, T> factory, BiConsumer notifier) { throw new AssertionError("This shouldn't happen!"); } } diff --git a/src/main/java/com/martmists/libgamerule/rules/BooleanRule.java b/src/main/java/com/martmists/libgamerule/rules/BooleanRule.java index 15f3fb1..a3fd7f3 100644 --- a/src/main/java/com/martmists/libgamerule/rules/BooleanRule.java +++ b/src/main/java/com/martmists/libgamerule/rules/BooleanRule.java @@ -9,7 +9,7 @@ public class BooleanRule extends GameRules.Rule implements ValueGetter { // Using this instead of GameRules.BooleanRule for ease of use - boolean value; + private boolean value; public BooleanRule(GameRules.RuleType ruleType, boolean value) { super(ruleType); diff --git a/src/main/java/com/martmists/libgamerule/rules/DoubleRule.java b/src/main/java/com/martmists/libgamerule/rules/DoubleRule.java index ff632b4..71b2c91 100644 --- a/src/main/java/com/martmists/libgamerule/rules/DoubleRule.java +++ b/src/main/java/com/martmists/libgamerule/rules/DoubleRule.java @@ -8,7 +8,7 @@ import net.minecraft.world.GameRules; public class DoubleRule extends GameRules.Rule implements ValueGetter { - double value; + private double value; public DoubleRule(GameRules.RuleType ruleType, double value) { super(ruleType); diff --git a/src/main/java/com/martmists/libgamerule/rules/EnumRule.java b/src/main/java/com/martmists/libgamerule/rules/EnumRule.java index 21aa3ce..18bb34c 100644 --- a/src/main/java/com/martmists/libgamerule/rules/EnumRule.java +++ b/src/main/java/com/martmists/libgamerule/rules/EnumRule.java @@ -8,8 +8,9 @@ import net.minecraft.world.GameRules; public class EnumRule> extends GameRules.Rule> implements ValueGetter { - Class clazz; - E value; + private Class clazz; + + private E value; public EnumRule(GameRules.RuleType> ruleType, E value) { super(ruleType); diff --git a/src/main/java/com/martmists/libgamerule/rules/IntRule.java b/src/main/java/com/martmists/libgamerule/rules/IntRule.java index 016bfe6..45b397c 100644 --- a/src/main/java/com/martmists/libgamerule/rules/IntRule.java +++ b/src/main/java/com/martmists/libgamerule/rules/IntRule.java @@ -9,8 +9,7 @@ public class IntRule extends GameRules.Rule implements ValueGetter { // Not using GameRules.IntRule for flexibility in create() - - int value; + private int value; public IntRule(GameRules.RuleType ruleType, int value) { super(ruleType); diff --git a/src/main/java/com/martmists/libgamerule/rules/StringRule.java b/src/main/java/com/martmists/libgamerule/rules/StringRule.java index 510f1f1..9d476cb 100644 --- a/src/main/java/com/martmists/libgamerule/rules/StringRule.java +++ b/src/main/java/com/martmists/libgamerule/rules/StringRule.java @@ -8,7 +8,7 @@ import net.minecraft.world.GameRules; public class StringRule extends GameRules.Rule implements ValueGetter { - String value; + private String value; public StringRule(GameRules.RuleType ruleType, String value) { super(ruleType);