Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unneeded RF Command Definitions - Command.h #37

Open
kb1lqd opened this issue Oct 26, 2016 · 0 comments
Open

Unneeded RF Command Definitions - Command.h #37

kb1lqd opened this issue Oct 26, 2016 · 0 comments

Comments

@kb1lqd
Copy link
Contributor

kb1lqd commented Oct 26, 2016

Documenting the code base found that APP_COMMAND_PAYLOAD_MAX_LEN and APP_COMMAND_RF_CONFIG_LEN are unneeded in the Applications>>command.h header file. This should implemented as a RF network stack MTU definition.

NOTE: APP_COMMAND_RF_PACKET_PAYLOAD_LEN is also unneeded or can be consolidated.

/** @name RF Command Definitions
*   @brief Definitions used to govern the operation of the RF commands
@{**/
#define APP_COMMAND_PAYLOAD_MAX_LEN 42 /**< Maximum allowable length in bytes of the RF command packets. This is directly determined by the MTU of the RF network stack */
#define APP_COMMAND_RF_CONFIG_LEN 19 /**< Length in bytes of the RF configuration (for all layers in the network stack) information */
/** @}*/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant