Fix #7759 - Routine calling overhead increased by factor 6 vs Firebird 4.0.0.

Author: asfernandes

src/jrd/req.h

@@ -174,14 +174,15 @@ class jrd_req : public pool_alloc<type_req>
 		void invalidate()
 		{
 			gmtTimeStamp.invalidate();
+			localTimeStampValid = localTimeValid = false;
 		}
 
 		ISC_TIMESTAMP getLocalTimeStamp(USHORT currentTimeZone) const
 		{
 			fb_assert(!gmtTimeStamp.isEmpty());
 
-			if (timeZone != currentTimeZone)
-				update(currentTimeZone);
+			if (!localTimeStampValid || timeZone != currentTimeZone)
+				update(currentTimeZone, true);
 
 			return localTimeStamp;
 		}
@@ -195,7 +196,7 @@ class jrd_req : public pool_alloc<type_req>
 		void setGmtTimeStamp(USHORT currentTimeZone, ISC_TIMESTAMP ts)
 		{
 			gmtTimeStamp = ts;
-			update(currentTimeZone);
+			update(currentTimeZone, false);
 		}
 
 		ISC_TIMESTAMP_TZ getTimeStampTz(USHORT currentTimeZone) const
@@ -215,7 +216,7 @@ class jrd_req : public pool_alloc<type_req>
 			ISC_TIME_TZ timeTz;
 
 			if (timeZone != currentTimeZone)
-				update(currentTimeZone);
+				update(currentTimeZone, false);
 
 			if (localTimeValid)
 			{
@@ -242,27 +243,33 @@ class jrd_req : public pool_alloc<type_req>
 			if (gmtTimeStamp.isEmpty())
 			{
 				Firebird::TimeZoneUtil::validateGmtTimeStamp(gmtTimeStamp);
-				update(currentTimeZone);
+				update(currentTimeZone, false);
 			}
 		}
 
 	private:
-		void update(USHORT currentTimeZone) const
+		void update(USHORT currentTimeZone, bool updateLocalTimeStamp) const
 		{
-			localTimeStamp = Firebird::TimeZoneUtil::timeStampTzToTimeStamp(
-				getTimeStampTz(currentTimeZone), currentTimeZone);
+			if (updateLocalTimeStamp)
+			{
+				localTimeStamp = Firebird::TimeZoneUtil::timeStampTzToTimeStamp(
+					getTimeStampTz(currentTimeZone), currentTimeZone);
+			}
+
+			localTimeStampValid = updateLocalTimeStamp;
 			timeZone = currentTimeZone;
 			localTimeValid = false;
 		}
 
 	private:
 		Firebird::TimeStamp gmtTimeStamp;		// Start time of request in GMT time zone
 
+		mutable bool localTimeStampValid;		// localTimeStamp calculation is expensive. So is it valid (calculated)?
+		mutable bool localTimeValid;			// localTime calculation is expensive. So is it valid (calculated)?
 		// These are valid only when !gmtTimeStamp.isEmpty(), so no initialization is necessary.
 		mutable ISC_TIMESTAMP localTimeStamp;	// Timestamp in timeZone's zone
 		mutable ISC_USHORT timeZone;			// Timezone borrowed from the attachment when updated
 		mutable ISC_TIME localTime;				// gmtTimeStamp converted to local time (WITH TZ)
-		mutable bool localTimeValid;			// localTime calculation is expensive. So is it valid (calculated)?
 	};
 
 	// Fields to support read consistency in READ COMMITTED transactions