Skip to content

Line "BLR to Source mapping:" may look broken when procedures.rdb$debug_info is queried using remote protocol #8590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pavel-zotov opened this issue Jun 7, 2025 · 2 comments · Fixed by #8594 · May be fixed by #8591
Closed

Line "BLR to Source mapping:" may look broken when procedures.rdb$debug_info is queried using remote protocol #8590

pavel-zotov opened this issue Jun 7, 2025 · 2 comments · Fixed by #8594 · May be fixed by #8591
Assignees
@hvlad
Labels
affect-version: 3.0.0 affect-version: 4.0.0 affect-version: 5.0.0 affect-version: 6.0 Initial fix-version: 4.0.6 fix-version: 5.0.3 fix-version: 6.0 Alpha 1 qa: covered by another tests type: bug

Comments

@pavel-zotov
Copy link

Consider script from attached .zip
gh-8579_-_make-nested-subroutines.sql.zip

Note: database creation / connect must use remote protocol.

On Windows and Linux its output has following tail:

Sub procedure SP_MAIN_SUB_PROC_00017:

Variables:
    Number Name
---------------------------------------
         0 N

BLR to Source mapping:
BLR offset       Line     Column
--------------------------------
        14        164          1
        21        165          1
        23        166          1


Sub procedure SP_MAIN_SUB_PROC_00018:

Variables:
    Number Name
---------------------------------------
         0 N

BLR to Source m
apping:
BLR offset       Line     Column
--------------------------------
        14        169          1
        21        170          1
        23        171          1

=======================================

(i.e. line "BLR to Source mapping:" is broken for sub_proc00018).

No such problem if we try to use only nested functions (instead of SPs) or just nested procedures (without functions).
@pavel-zotov pavel-zotov mentioned this issue Jun 7, 2025
Closed
asfernandes added a commit that referenced this issue Jun 10, 2025
@asfernandes
Fix #8590 - Line "BLR to Source mapping:" may look broken when proced…
2f70188 
…ures.rdb$debug_info is queried using remote protocol.
@asfernandes asfernandes linked a pull request Jun 10, 2025 that will close this issue
Fix #8590 - Line "BLR to Source mapping:" may look broken when procedures.rdb$debug_info is queried using remote protocol. #8591
Open
@asfernandes asfernandes mentioned this issue Jun 10, 2025
Open
@asfernandes asfernandes self-assigned this Jun 10, 2025
hvlad added a commit that referenced this issue Jun 10, 2025
@hvlad
Fixed string_filter (used with internal blob types) that could not re…
c867f34 
…port isc_segment.

It fixes #8590 and other similar cases.
@hvlad hvlad mentioned this issue Jun 10, 2025
Merged
@asfernandes asfernandes removed their assignment Jun 10, 2025
@hvlad hvlad self-assigned this Jun 11, 2025
@hvlad
Copy link
Member

hvlad commented Jun 11, 2025

Reopen for backporting

@hvlad hvlad reopened this Jun 11, 2025
@hvlad hvlad closed this as completed Jun 11, 2025
@pavel-zotov
Copy link
Author

::: QA note :::
Test not needed, see tests/bugs/gh_8579_test.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hvlad hvlad

Labels
affect-version: 3.0.0 affect-version: 4.0.0 affect-version: 5.0.0 affect-version: 6.0 Initial fix-version: 4.0.6 fix-version: 5.0.3 fix-version: 6.0 Alpha 1 qa: covered by another tests type: bug
Projects
None yet
Milestone
No milestone
3 participants
@asfernandes @hvlad @pavel-zotov