Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP/CUDA Language support in CMake build system #57

Closed
fluidnumerics-joe opened this issue Oct 1, 2024 · 0 comments · Fixed by #102 · May be fixed by #101
Closed

HIP/CUDA Language support in CMake build system #57

fluidnumerics-joe opened this issue Oct 1, 2024 · 0 comments · Fixed by #102 · May be fixed by #101

Comments

@fluidnumerics-joe
Copy link
Member

This stems from a review in PR #53

Ultimately, we want to be able to use the language support for HIP/CUDA rather than bringing in HIP/CUDA through find_package, which is deprecated (though still usable). From the CMake documentation:

It is no longer necessary to use this module or call find_package(CUDA) for compiling CUDA code. Instead, list CUDA among the languages named in the top-level call to the project() command, or call the enable_language() command with CUDA. Then one can add CUDA (.cu) sources directly to targets similar to other languages.

At the moment we are doing a hack overrided the CXX compiler with either hipcc or nvcc.

The reason we're doing it this way (hacky) at the moment is that we get segmentation faults on our AMD GPU tests when using the HIP language support via Cmake, for some yet unknown reason.

This was referenced Jan 18, 2025
@fluidnumerics-joe fluidnumerics-joe linked a pull request Jan 22, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant