remove keypath indexing

Author: CarloLucibello

src/functor.jl

@@ -37,8 +37,6 @@ function makefunctor(m::Module, T, fs = fieldnames(T))
       reconstruct(y::NamedTuple) = $T($(escargs_nt...))
       return (;$(escfs...)), reconstruct
     end
-
-    Base.getindex(x::$T, kp::KeyPath) = getkeypath(x, kp)
   end
 end
 

src/keypath.jl

@@ -68,8 +68,6 @@ _haskey(x, k::AbstractString) = haskey(x, k)
 
 Return the value in `x` at the path `kp`.
 
-For object types on which `@functor` has been applied, `x[kp]` is equivalent to `getkeypath(x, kp)`.
-
 See also [`haskeypath`](@ref).
 
 # Examples

test/keypath.jl

@@ -22,19 +22,14 @@
         @test getkeypath(x, KeyPath(:b, :c)) == 4
         @test getkeypath(x, KeyPath(:b, "d", 2)) == 6
 
-        @testset "@functor defines keypath indexing" begin
-            struct Tkp
-                a
-                b
-                c
-            end
-            @functor Tkp
-                
-            x = Tkp(3, Tkp(4, 5, 6), (7, 8))
-            kp = KeyPath(:b, :b, 1)
-            @test x[kp] == getkeypath(x, kp)
-            @test x[KeyPath(:c, :2)] == 8
+        struct Tkp
+            a
+            b
+            c
         end
+        x = Tkp(3, Tkp(4, 5, (6, 7)), 8)
+        kp = KeyPath(:b, :c, 2)
+        @test getkeypath(x, kp) == 7
     end
 
     @testset "haskeypath" begin