Port some tests to work on MS SQL

Author: sudqijawabreh

tests/NpgsqlFSharpAnalyzer.Tests/Tests.fs

@@ -74,9 +74,9 @@ let tests =
             use db = createTestDatabase()
 
             Sql.connect db.ConnectionString
-            |> Sql.query "CREATE EXTENSION IF NOT EXISTS citext;CREATE SCHEMA test; CREATE TABLE test.articles (id BIGINT PRIMARY KEY NOT NULL,art_name CITEXT UNIQUE NOT NULL, stock BIGINT NOT NULL);"
+            |> Sql.query "CREATE SCHEMA test CREATE TABLE test.articles (id BIGINT PRIMARY KEY NOT NULL,art_name TEXT NOT NULL, stock BIGINT NOT NULL);"
             |> Sql.executeNonQuery
-            |> raiseWhenFailed
+            |> ignore
 
             match context (find "../examples/hashing/MultipleNestedModules.fs") with
             | None -> failwith "Could not crack project"
@@ -89,16 +89,16 @@ let tests =
                 | Result.Ok schema ->
                     let errors = SqlAnalysis.analyzeOperation operations.[0] db.ConnectionString schema
                     Expect.equal 1 errors.Length "There should be one error message"
-                    Expect.stringContains errors.[0].Message "column \"x\" does not exist" "There should be an error message"
+                    Expect.stringContains errors.[0].Message "Invalid column name 'x'" "There should be an error message"
         }
 
         test "Semantic analysis using FSX: finding SQL blocks in multiple nested modules which query a non-public schema" {
             use db = createTestDatabase()
 
             Sql.connect db.ConnectionString
-            |> Sql.query "CREATE EXTENSION IF NOT EXISTS citext;CREATE SCHEMA test; CREATE TABLE test.articles (id BIGINT PRIMARY KEY NOT NULL,art_name CITEXT UNIQUE NOT NULL, stock BIGINT NOT NULL);"
+            |> Sql.query "CREATE SCHEMA test CREATE TABLE test.articles (id BIGINT PRIMARY KEY NOT NULL,art_name TEXT NOT NULL, stock BIGINT NOT NULL);"
             |> Sql.executeNonQuery
-            |> raiseWhenFailed
+            |> ignore
 
             match context (find "../examples/hashing/MultipleNestedModules.fsx") with
             | None -> failwith "Could not crack project"
@@ -111,7 +111,7 @@ let tests =
                 | Result.Ok schema ->
                     let errors = SqlAnalysis.analyzeOperation operations.[0] db.ConnectionString schema
                     Expect.equal 1 errors.Length "There should be one error message"
-                    Expect.stringContains errors.[0].Message "column \"x\" does not exist" "There should be an error message"
+                    Expect.stringContains errors.[0].Message "Invalid column name 'x'" "There should be an error message"
         }
 
         test "Syntactic analysis: SQL block found from top-level expression in module" {
@@ -337,13 +337,14 @@ let tests =
                     Expect.isEmpty messages "No errors returned"
         }
 
-        test "Semantic analysis: casting non-nullable columns stays non-nullable" {
+        // https://sqlsunday.com/2019/06/05/cast-convert-makes-expressions-nullable/
+        test "Semantic analysis: casting non-nullable columns doesn't stay non-nullable in MS SQL" {
             use db = createTestDatabase()
 
             Sql.connect db.ConnectionString
-            |> Sql.query "CREATE TABLE users (user_id bigserial primary key, username text not null)"
+            |> Sql.query "CREATE TABLE users (user_id bigint identity(1,1) NOT NULL primary key, username text not null)"
             |> Sql.executeNonQuery
-            |> raiseWhenFailed
+            |> ignore
 
             match context (find "../examples/hashing/castingNonNullableStaysNonNullable.fs") with
             | None -> failwith "Could not crack project"
@@ -354,7 +355,7 @@ let tests =
                 | Result.Ok schema ->
                     let blocks = SyntacticAnalysis.findSqlOperations context
                     let messages = blocks |> List.collect (fun block -> SqlAnalysis.analyzeOperation block db.ConnectionString schema)
-                    Expect.isEmpty messages "No errors returned"
+                    Expect.equal 3 messages.Length "Three errors returned"
         }
 
         test "Semantic analysis: incorrect queries in executeTransaction are detected" {
@@ -502,7 +503,8 @@ let tests =
                 Expect.isFalse rolesColumn.Nullable "The column is not nullable"
         }
 
-        test "SQL schema analysis with user defined arrays" {
+        // skip this test
+        ptest "SQL schema analysis with user defined arrays" {
             use db = createTestDatabase ()
 
             Sql.connect db.ConnectionString

tests/examples/hashing/castingNonNullableStaysNonNullable.fs

@@ -5,17 +5,17 @@ open Npgsql.FSharp
 let userIds connection =
     connection
     |> Sql.connect
-    |> Sql.query "SELECT user_id::text AS useridtext FROM users"
+    |> Sql.query "SELECT CAST(user_id as nvarchar) AS useridtext FROM users"
     |> Sql.execute (fun read -> read.text "useridtext")
 
 let moreIds connection =
     connection
     |> Sql.connect
-    |> Sql.query "SELECT user_id::text as useridtext FROM users"
+    |> Sql.query "SELECT CAST (user_id as nvarchar) as useridtext FROM users"
     |> Sql.execute (fun read -> read.text "useridtext")
 
 let withoutAlias connection =
     connection
     |> Sql.connect
-    |> Sql.query "SELECT user_id::text FROM users"
+    |> Sql.query "SELECT CAST (user_id as nvarchar) FROM users"
     |> Sql.execute (fun read -> read.text "user_id")