Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Rename or remove autoprefixer-core #18

Open
ai opened this issue Mar 11, 2016 · 17 comments
Open

Rename or remove autoprefixer-core #18

ai opened this issue Mar 11, 2016 · 17 comments

Comments

@ai
Copy link

ai commented Mar 11, 2016

autoprefixer-core was renamed to autoprefixer and old npm package was deprecated.

I tried to make a PR, but I didn’t find how you use autoprefixer-core.

@ai
Copy link
Author

ai commented Mar 11, 2016

@kenwheeler I can send a PR if you told me where autoprefixer-core is used.

@ai
Copy link
Author

ai commented Mar 11, 2016

Same thing with spectacle main repo.

/cc @knowbody

@kenwheeler
Copy link
Contributor

I believe thats coming from Radium. Going to try to bump the version and see if that fixes it.

@kenwheeler
Copy link
Contributor

Unless you want the PR. In which case, let me know and I'll merge it when it comes in.

@ai
Copy link
Author

ai commented Mar 11, 2016

This type of investigation is not a good start in project for me :).

@kenwheeler
Copy link
Contributor

Sorry for any inconvenience it caused you. It actually looks like you were the maintainer of autoprefixer-core? Oddly, I've used spectacle 3 times in the last two months and haven't hit this issue. When did you deprecate the package?

@ai
Copy link
Author

ai commented Mar 11, 2016

We deprecated it 6 month ago. https://www.npmjs.com/package/autoprefixer-core

@kenwheeler
Copy link
Contributor

I just cloned fresh and ran the project without a problem. Are you on npm2?

@ai
Copy link
Author

ai commented Mar 11, 2016

@kenwheeler open a autoprefixer-core docs, it is deprecated ;).

@ai
Copy link
Author

ai commented Mar 11, 2016

Also we should remove dependency from project, if nobody know where it is used ;)

@kenwheeler
Copy link
Contributor

Ok, I suspect it had something to do with css-loader. I'll get this removed once I updated all the package versions and make sure its stable.

@ai
Copy link
Author

ai commented Mar 11, 2016

css-loader uses PostCSS, but it has no Autoprefixer ;) https://github.com/webpack/css-loader/blob/master/package.json

@kenwheeler
Copy link
Contributor

Did it used to?

@kenwheeler
Copy link
Contributor

looks like pulling that dep out has no effect on the lib, so if you want to submit PRs to remove it, please do.

@ai
Copy link
Author

ai commented Mar 11, 2016

Do it yourself :)

@kenwheeler
Copy link
Contributor

Alright, you offered up above, so I didn't know if you wanted the credit for the find.

@knowbody
Copy link

@kenwheeler are you going to work on that, or do you want me to have a look into it?

edit: had to use the GH reaction for the first time, and it's on my own post lol

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants