Skip to content

React 19 - defaultProps removed breaks stuff like FullScreen #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
AndyOGo opened this issue May 9, 2025 · 0 comments
Open
3 tasks done

React 19 - defaultProps removed breaks stuff like FullScreen #1350

AndyOGo opened this issue May 9, 2025 · 0 comments

Comments

@AndyOGo
Copy link

AndyOGo commented May 9, 2025

Prerequisites

Describe Your Environment

What version of Spectacle are you using? (can be found by running npm list --depth 0 spectacle)

[email protected]

What version of React are you using? (can be found by running npm list --depth 0 react)

[email protected]

What browser are you using? (e.g., Chrome 105.0.5195.102, Safari 16.0)
Edge

What platform are you on? (e.g., Windows, macOS, iOS, Android)
Windows

Describe the Problem

React 19 removed defaultProps and other APIs.
https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

Expected behavior: [What you expect to happen] <FullScreen> should have a default size

Actual behavior: [What actually happens] <FullScreen> has no default size

Additional Information

Affected code
https://github.com/search?q=repo%3AFormidableLabs%2Fspectacle%20defaultProps%20&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant