From f89c6bdf209f464807c2a2048c7ccf35c481f35a Mon Sep 17 00:00:00 2001 From: Sean Anderson Date: Wed, 29 May 2024 23:28:33 -0400 Subject: [PATCH] site: js: Use let when introducing new variables In strict mode, directly assigning to a variable is forbidden. Use let (or const) instead. Signed-off-by: Sean Anderson --- trends/site/static/js/dates.js | 4 ++-- trends/site/static/js/filter.js | 2 +- trends/site/static/js/sort.js | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/trends/site/static/js/dates.js b/trends/site/static/js/dates.js index 3abea5d..156983b 100644 --- a/trends/site/static/js/dates.js +++ b/trends/site/static/js/dates.js @@ -5,11 +5,11 @@ var date_formatter = new Intl.DateTimeFormat('und', {dateStyle: 'medium'}); var datetime_formatter = new Intl.DateTimeFormat('und', {dateStyle: 'medium', timeStyle: 'short'}); document.addEventListener('DOMContentLoaded', () => { - for (date of document.getElementsByClassName("datetime")) + for (let date of document.getElementsByClassName("datetime")) date.textContent = datetime_formatter.format( new Date(date.getAttribute('timestamp') * 1000)); - for (date of document.getElementsByClassName("date")) + for (let date of document.getElementsByClassName("date")) date.textContent = date_formatter.format( new Date(date.getAttribute('timestamp') * 1000)); }); diff --git a/trends/site/static/js/filter.js b/trends/site/static/js/filter.js index 6fd4aaf..7266cea 100644 --- a/trends/site/static/js/filter.js +++ b/trends/site/static/js/filter.js @@ -38,7 +38,7 @@ function render_option(data, escape) { } document.addEventListener('DOMContentLoaded', () => { - input = document.getElementById('players_input'); + let input = document.getElementById('players_input'); if (input != null) { new TomSelect(document.getElementById('players_input'), { plugins: ['remove_button'], diff --git a/trends/site/static/js/sort.js b/trends/site/static/js/sort.js index 0f362f0..b8ac17a 100644 --- a/trends/site/static/js/sort.js +++ b/trends/site/static/js/sort.js @@ -9,7 +9,7 @@ function cell_value(row, column) { let i = 0; let cell; for (let td of row.children) { - cs = colspan(td) || 1; + let cs = colspan(td) || 1; if (column >= i && column < i + cs) { cell = td; break; @@ -74,7 +74,7 @@ function sort_rows(rows, insert, column, asc, reverse) { function register_sort(table, header) { let column = 0; - for (th of header.parentNode.children) { + for (const th of header.parentNode.children) { if (th === header) { break; }