Skip to content

Commit 5ba1d9b

Browse files
fwk: Remove unimplemented FN+S
There is no need for the FN+S shortcut. The PRT SCR key works as sysrq. This is the same as on QMK with `KC_PRINT_SCREEN` ``` > sudo libinput debug-events --show-keycodes | grep KEYBOARD_KEY -event2 KEYBOARD_KEY +4.295s KEY_SYSRQ (99) pressed event2 KEYBOARD_KEY +0.067s KEY_SYSRQ (99) released ``` BUG=Customer was asking why FN+S wasn't working. BRANCH=fwk-main TEST=`zmake build marigold` Signed-off-by: Daniel Schaefer <[email protected]> Co-authored-by: Quin Chou <[email protected]> (cherry picked from commit 281d6baef895f9a1548d6ed8f430d80918c6809c)
1 parent ac0547a commit 5ba1d9b

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

zephyr/program/framework/src/keyboard_customization_13.c

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -312,12 +312,7 @@ int hotkey_F1_F12(uint16_t *key_code, uint16_t fn, int8_t pressed)
312312
}
313313
break;
314314
case SCANCODE_F11:
315-
/*
316-
* TODO this might need an
317-
* extra key combo of:
318-
* 0xE012 0xE07C to simulate
319-
* PRINT_SCREEN
320-
*/
315+
/* Print screen / SYSRQ */
321316
if (fn_table_media_set(pressed, KB_FN_F11))
322317
*key_code = 0xE07C;
323318
break;
@@ -346,10 +341,6 @@ int hotkey_special_key(uint16_t *key_code, int8_t pressed)
346341
if (fn_table_set(pressed, KB_FN_K))
347342
*key_code = SCANCODE_SCROLL_LOCK;
348343
break;
349-
case SCANCODE_S: /* TODO: SYSRQ */
350-
/*if (!fn_table_set(pressed, KB_FN_S))*/
351-
352-
break;
353344
case SCANCODE_LEFT: /* HOME */
354345
if (fn_table_set(pressed, KB_FN_LEFT))
355346
*key_code = 0xe06c;

0 commit comments

Comments
 (0)