feat(watermarker): add frequency analysis for Watermarks #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schiphorst-ISST
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a static frequency analysis function to the Watermark class and the option to only return the most frequent Watermark(s) from any Watermarker function that returns a list of Watermarks, as described by the additional context in the linked issue. Both Watermarker.kt and JvmWatermarker.kt use it by default.
Please note that frequency analysis is separate from squashing and can be used alone or in conjunction with it wherever supported.
Linked Issue(s)
Fixes #190
CLA
By submitting this pull request, I have read the Corporate Contributor License Agreement (CLA) and I hereby accept and sign the CLA.