Skip to content

Commit cace0b8

Browse files
Update create zip process in release.yml for security guidelines (#122)
1 parent e86b531 commit cace0b8

File tree

1 file changed

+15
-7
lines changed

1 file changed

+15
-7
lines changed

.github/workflows/release.yml

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,21 +109,27 @@ jobs:
109109
cd coreMQTT-Agent
110110
git submodule update --init --checkout --recursive
111111
- name: Create ZIP
112+
env:
113+
VERSION_NUMBER: ${{ github.event.inputs.version_number }}
112114
run: |
113-
zip -r coreMQTT-Agent-${{ github.event.inputs.version_number }}.zip coreMQTT-Agent -x "*.git*"
115+
zip -r coreMQTT-Agent-"$VERSION_NUMBER".zip coreMQTT-Agent -x "*.git*"
114116
ls ./
115117
- name: Validate created ZIP
118+
env:
119+
VERSION_NUMBER: ${{ github.event.inputs.version_number }}
116120
run: |
117121
mkdir zip-check
118-
mv coreMQTT-Agent-${{ github.event.inputs.version_number }}.zip zip-check
122+
mv coreMQTT-Agent-"$VERSION_NUMBER".zip zip-check
119123
cd zip-check
120-
unzip coreMQTT-Agent-${{ github.event.inputs.version_number }}.zip -d coreMQTT-Agent-${{ github.event.inputs.version_number }}
121-
ls coreMQTT-Agent-${{ github.event.inputs.version_number }}
122-
diff -r -x "*.git*" coreMQTT-Agent-${{ github.event.inputs.version_number }}/coreMQTT-Agent/ ../coreMQTT-Agent/
124+
unzip coreMQTT-Agent-"$VERSION_NUMBER".zip -d coreMQTT-Agent-"$VERSION_NUMBER"
125+
ls coreMQTT-Agent-"$VERSION_NUMBER"
126+
diff -r -x "*.git*" coreMQTT-Agent-"$VERSION_NUMBER"/coreMQTT-Agent/ ../coreMQTT-Agent/
123127
cd ../
124128
- name: Build
129+
env:
130+
VERSION_NUMBER: ${{ github.event.inputs.version_number }}
125131
run: |
126-
cd zip-check/coreMQTT-Agent-${{ github.event.inputs.version_number }}/coreMQTT-Agent
132+
cd zip-check/coreMQTT-Agent-"$VERSION_NUMBER"/coreMQTT-Agent
127133
sudo apt-get install -y lcov
128134
cmake -S test -B build/ \
129135
-G "Unix Makefiles" \
@@ -132,8 +138,10 @@ jobs:
132138
-DCMAKE_C_FLAGS='--coverage -Wall -Wextra -Werror -DNDEBUG'
133139
make -C build/ all
134140
- name: Test
141+
env:
142+
VERSION_NUMBER: ${{ github.event.inputs.version_number }}
135143
run: |
136-
cd zip-check/coreMQTT-Agent-${{ github.event.inputs.version_number }}/coreMQTT-Agent/build/
144+
cd zip-check/coreMQTT-Agent-"$VERSION_NUMBER"/coreMQTT-Agent/build/
137145
ctest -E system --output-on-failure
138146
cd ..
139147
- name: Create artifact of ZIP

0 commit comments

Comments
 (0)