Skip to content

Commit 1a6c9e9

Browse files
authored
Make constants imported from @fortawesome/free-solid-svg-icons ordered by name again (#3958)
* $ Make constants imported from @fortawesome/free-solid-svg-icons ordered by name again * ~ Add code comment about constant list ordering
1 parent 692a3c7 commit 1a6c9e9

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/renderer/main.js

+8-4
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ import router from './router/index'
55
import store from './store/index'
66
import i18n from './i18n/index'
77
import { library } from '@fortawesome/fontawesome-svg-core'
8+
// Please keep the list of constants sorted by name
9+
// to avoid code conflict and duplicate entries
810
import {
911
faAngleDown,
1012
faArrowDown,
@@ -26,6 +28,8 @@ import {
2628
faExchangeAlt,
2729
faExclamationCircle,
2830
faExternalLinkAlt,
31+
faEye,
32+
faEyeSlash,
2933
faFileDownload,
3034
faFileVideo,
3135
faFilter,
@@ -57,8 +61,6 @@ import {
5761
faTimes,
5862
faTimesCircle,
5963
faUsers,
60-
faEye,
61-
faEyeSlash,
6264
} from '@fortawesome/free-solid-svg-icons'
6365
import {
6466
faBitcoin,
@@ -72,6 +74,8 @@ Vue.config.devtools = process.env.NODE_ENV === 'development'
7274
Vue.config.performance = process.env.NODE_ENV === 'development'
7375
Vue.config.productionTip = process.env.NODE_ENV === 'development'
7476

77+
// Please keep the list of constants sorted by name
78+
// to avoid code conflict and duplicate entries
7579
library.add(
7680
// solid icons
7781
faAngleDown,
@@ -94,6 +98,8 @@ library.add(
9498
faExchangeAlt,
9599
faExclamationCircle,
96100
faExternalLinkAlt,
101+
faEye,
102+
faEyeSlash,
97103
faFileDownload,
98104
faFileVideo,
99105
faFilter,
@@ -125,8 +131,6 @@ library.add(
125131
faTimes,
126132
faTimesCircle,
127133
faUsers,
128-
faEye,
129-
faEyeSlash,
130134

131135
// brand icons
132136
faGithub,

0 commit comments

Comments
 (0)